Add inactive donation site filtering and reactivate buttons #5094
+146
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM -- I did notice a further issue with inactive donation sites (that if you have a donation with an inactive site, you effectively can't edit the donation) -- and have added it to the queue of proto-issues. |
awwaiid
requested changes
Mar 14, 2025
| @@ -57,14 +60,28 @@ def deactivate | |||
| donation_site.deactivate! | |||
| rescue => e | |||
| flash[:error] = e.message | |||
| redirect_back(fallback_location: items_path) | |||
| redirect_back(fallback_location: donation_sites_path) | |||
awwaiid
approved these changes
Mar 15, 2025
|
@coalest: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4543
Description
Type of change
How Has This Been Tested?
Added new request specs
Screenshots