Skip to content

Conversation

@mrb0nk500
Copy link

This is needed to match Flash Player's event order.

This allows Super Mario 63 to properly load custom levels from the level designer menu.

Also, this is my first time working with Rust, so if doesn't look too great, that's why.

@mrb0nk500
Copy link
Author

Also, for some reason, the test I made doesn't work with the test runner.
It almost seems like the test runner is using an older version, and not my version.

@n0samu
Copy link
Member

n0samu commented Jul 24, 2023

Hello and welcome! You can run cargo fmt to fix the formatting issues with your code. Once the formatting checks are satisfied, the actual tests should run properly!

@mrb0nk500
Copy link
Author

It took way too many hours to get to this simple fix. lol

@mrb0nk500
Copy link
Author

mrb0nk500 commented Jul 24, 2023

Probably need to enable it only when using AVM1.
Not sure how to do that, or if that's necessary.

@Lord-McSweeney
Copy link
Collaborator

Lord-McSweeney commented Jul 24, 2023

I don't understand what you mean by that, but the test seems to be incorrectly written. The expected output differs from the output given by the test runner, so some part of the written test (not necessarily the actual bug fix for Ruffle that you wrote) is probably incorrect.

@Lord-McSweeney
Copy link
Collaborator

#9295 might intersect with this.

@mrb0nk500
Copy link
Author

Well, I know mine works with onMouseDown, since that's what I was trying to fix.

@mrb0nk500
Copy link
Author

I had also thought of optimizing event propagation, by caching which MovieClips have propagating events, and only propagate if the parent has any children (including their children) with propagating events.

But I couldn't get it to work.

@mrb0nk500
Copy link
Author

I don't understand what you mean by that, but the test seems to be incorrectly written. The expected output differs from the output given by the test runner, so some part of the written test (not necessarily the actual bug fix for Ruffle that you wrote) is probably incorrect.

The output was made from Flash Player, and done manually.

@mrb0nk500
Copy link
Author

I just checked, it's the coords I used in input.json

@mrb0nk500
Copy link
Author

mrb0nk500 commented Jul 24, 2023

I just checked, it's the coords I used in input.json

It makes sense that this was the issue, given that I wrote that late last night, and was very tired.

@adrian17 adrian17 self-requested a review July 24, 2023 20:25
@Dinnerbone Dinnerbone added the waiting-on-review Waiting on review from a Ruffle team member label Jul 24, 2023
@mrb0nk500 mrb0nk500 force-pushed the master branch 2 times, most recently from 0633298 to 5251b13 Compare July 26, 2023 18:41
This is needed to match Flash Player's event order.

This allows Super Mario 63 to properly load custom levels from the level
designer menu.

Also, this is my first time working with Rust, so if doesn't look too
great, that's why.
@danielhjacobs danielhjacobs added A-core Area: Core player, where no other category fits T-fix Type: Bug fix (in something that's supposed to work already) labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-core Area: Core player, where no other category fits T-fix Type: Bug fix (in something that's supposed to work already) waiting-on-review Waiting on review from a Ruffle team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants