-
-
Notifications
You must be signed in to change notification settings - Fork 958
core: Push propagating MovieClip events in front of the action queue
#12286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Also, for some reason, the test I made doesn't work with the test runner. |
|
Hello and welcome! You can run |
|
It took way too many hours to get to this simple fix. lol |
|
Probably need to enable it only when using AVM1. |
|
I don't understand what you mean by that, but the test seems to be incorrectly written. The expected output differs from the output given by the test runner, so some part of the written test (not necessarily the actual bug fix for Ruffle that you wrote) is probably incorrect. |
|
#9295 might intersect with this. |
|
Well, I know mine works with |
|
I had also thought of optimizing event propagation, by caching which But I couldn't get it to work. |
The output was made from Flash Player, and done manually. |
|
I just checked, it's the coords I used in input.json |
It makes sense that this was the issue, given that I wrote that late last night, and was very tired. |
0633298 to
5251b13
Compare
This is needed to match Flash Player's event order. This allows Super Mario 63 to properly load custom levels from the level designer menu. Also, this is my first time working with Rust, so if doesn't look too great, that's why.
This is needed to match Flash Player's event order.
This allows Super Mario 63 to properly load custom levels from the level designer menu.
Also, this is my first time working with Rust, so if doesn't look too great, that's why.