web: For all tests that polyfill with Ruffle, wait for element to exist

[danielhjacobs]

I can switch to playAndMonitor, but this should suffice and many tests do this already.

[danielhjacobs]

Unsure how to deal with these, which are testing that Ruffle does not polyfill certain elements:

• https://github.com/ruffle-rs/ruffle/blob/master/web/packages/selfhosted/test/polyfill/embed_youtube/test.ts
• https://github.com/ruffle-rs/ruffle/blob/master/web/packages/selfhosted/test/polyfill/object_youtube/test.ts
• https://github.com/ruffle-rs/ruffle/blob/master/web/packages/selfhosted/test/polyfill/object_inside_audio/test.ts
• https://github.com/ruffle-rs/ruffle/blob/master/web/packages/selfhosted/test/polyfill/embed_inside_audio/test.ts
• https://github.com/ruffle-rs/ruffle/blob/master/web/packages/selfhosted/test/polyfill/embed_missing_src/test.ts
• https://github.com/ruffle-rs/ruffle/blob/master/web/packages/selfhosted/test/polyfill/pdf_with_get/test.ts
• https://github.com/ruffle-rs/ruffle/blob/master/web/packages/selfhosted/test/polyfill/pdf/test.ts
• https://github.com/ruffle-rs/ruffle/blob/master/web/packages/selfhosted/test/polyfill/embed_wrong_type/test.ts
• https://github.com/ruffle-rs/ruffle/blob/master/web/packages/selfhosted/test/polyfill/object_missing_data/test.ts

[danielhjacobs]

Realistically, the only option for the ones where we're testing if elements do not polyfill with Ruffle is await browser.pause(5000) I guess, but that will make them take at least 5 seconds unconditionally. A lower number may work too.

[danielhjacobs]

I can't imagine this is bad to do, but neither await browser.$("<ruffle-embed />").waitForExist(); nor playAndMonitor seem to be sufficient to stop embed_unexpected_string failing.

Edit: Unrelated issue

[danielhjacobs]

Reviewer information: this is to account for the small chance that the tests run after line 134 here finishes and before line 144 finishes:

ruffle/web/packages/core/src/public/setup/public-api.ts

Lines 134 to 144 in e31d834

	this.invoked = true;
	this.newestName = this.newestSourceName();
	if (this.newestName === null) {
	throw new Error("No registered Ruffle source!");
	}
	const polyfills =
	"polyfills" in this.config ? this.config.polyfills : true;
	if (polyfills !== false) {
	this.sources[this.newestName]!.polyfill();

For the tests that Ruffle does not polyfill certain elements, #22490 was opened. It adds to the Public API a new boolean, initialized, which is set to true after the above lines. These tests could alternatively use the new function added there, but this could also be merged as-is. Either way works.