avm2: Handle invalid ShaderData parameter assignments #22679
+341
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuchAFuriousDeath
force-pushed
the
shader-param-default-values
branch
2 times, most recently
from
64a168e to
674476b
Compare
danielhjacobs
added
A-avm2
SuchAFuriousDeath
force-pushed
the
shader-param-default-values
branch
3 times, most recently
from
8f34538 to
473531b
Compare
When setting `shader.data.param = value` directly instead of the correct `shader.data.param.value = [value]`, Flash silently uses the parameter's default value from shader metadata. Previously Ruffle would error with "Shader property is not an object". Fixes ruffle-rs#17883, fixes ruffle-rs#18768, fixes ruffle-rs#14540, fixes ruffle-rs#22686
SuchAFuriousDeath
force-pushed
the
shader-param-default-values
branch
from
473531b to
9f3a2c4
Compare
SuchAFuriousDeath
force-pushed
the
shader-param-default-values
branch
from
9f3a2c4 to
adc60de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #22610 because of let chains.
Fixes #17883, fixes #18768 and fixes #14540 (tested), fixes #22686.
All 4 are actually the same game, so #17883, #18768 and #22686 are actually duplicates.