avm1: Fix MovieClipReference laundering issue #22711
Open
+36
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuchAFuriousDeath
force-pushed
the
fix-reference-laundering
branch
2 times, most recently
from
4b18b7a to
7862c56
Compare
|
Out of curiosity, would this fix #22075? It sounds very similar to the example reproduction in #15265 (comment). |
Collaborator
Author
|
I tried and it doesn't. I can try to take a look, but not making any promises. |
SuchAFuriousDeath
force-pushed
the
fix-reference-laundering
branch
from
7862c56 to
7e8992b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15265 (I can't reproduce it though, maybe I'm doing something wrong, but the game works for me with or without these changes)
This resurrects (and supersedes) #20840. Authorship retained. I barely changed anything, so not adding myself as a co-author.
Note: this merges the 2 commits from the original into 1 because it makes more sense to me (the code got refactored since and one commit would be just a 1-line change, it doesn't make sense to split it off to me).