Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#Angular: App updates during login procedure and log in details are lost and have to be re-entered #704

Open
runboxdave opened this issue Aug 5, 2020 · 5 comments · May be fixed by #1297
Open

#Angular: App updates during login procedure and log in details are lost and have to be re-entered #704

runboxdave opened this issue Aug 5, 2020 · 5 comments · May be fixed by #1297
Assignees
@castaway
Labels
enhancement New feature or request P2-high
Milestone
Rán

Comments

@runboxdave
Copy link

Please stop the app from updating during the log in procedure when there is a new version. Log in details are lost when this happens and have to be re-entered :)
@runboxdave runboxdave added the enhancement New feature or request label Aug 5, 2020
@gtandersen gtandersen added the P4-low Priority low label Aug 6, 2020
@gtandersen gtandersen removed their assignment Aug 6, 2020
@gtandersen
Copy link
Contributor

I don't think I have experienced this issue but can see that it would be annoying.

@gtandersen gtandersen added P3-medium Priority medium and removed P4-low Priority low labels Nov 27, 2020
@runboxdave
Copy link
Author

It's one of those things where the more you use Runbox the less likely you are to come across it :) However, if you have an account that you only periodically log in to via the web interface then it is more likely that you will come across it as there could have been an update.

@gtandersen gtandersen changed the title App updates during log in procedure and log in details are lost and have to be re-entered App updates during login procedure and log in details are lost and have to be re-entered Feb 1, 2022
@gtandersen gtandersen added P1-urgent Priority urgent and removed P3-medium Priority medium labels Feb 1, 2022
@gtandersen gtandersen added this to the General quality milestone Feb 1, 2022
@castaway
Copy link
Contributor

Couple of thoughts:

  • What we currently do is load the software update service, wait 60 seconds, then check if there's an update
  • I'm fairly sure if the user says "no" to reload right now, it will present the same prompt again in another 60 seconds so we don't have to accept the first one.. however I can see that most presumably hit the button on the first prompt, and it can still arrive mid login
  • We can change it to either:
    • Show prompts for an update as soon as its available (is probably faster than 60 seconds)
    • Wait much longer to check / between checks
    • Get notified of updates rather than polling

@gtandersen
Copy link
Contributor

It is probably better to check for updates right away as the user then gets that part out of the way before it can interfere with either logging in or just using the app.

@castaway castaway self-assigned this Jun 21, 2022
castaway added a commit that referenced this issue Aug 1, 2022
@castaway
fix(updates): Check immediately for updates, and then not for 5 mins
c505292 
Fixes #704
castaway added a commit that referenced this issue Aug 1, 2022
@castaway
fix(updates): Use isStable to check as soon as possible for updates
5b5c8fd 
Fixes: #704
castaway added a commit that referenced this issue Aug 2, 2022
@castaway
fix(updates): Use isStable to check as soon as possible for updates
cef5106 
Fixes: #704
@castaway castaway linked a pull request Aug 22, 2022 that will close this issue
Open
@gtandersen gtandersen added P2-high and removed P1-urgent Priority urgent labels May 25, 2023
@gtandersen gtandersen modified the milestones: General quality, Gleipnir Oct 9, 2023
@shadowcat-mdk shadowcat-mdk modified the milestones: Gleipnir, Freyja Mar 5, 2024
@shadowcat-mdk shadowcat-mdk changed the title App updates during login procedure and log in details are lost and have to be re-entered #Angular: App updates during login procedure and log in details are lost and have to be re-entered Mar 5, 2024
@shadowcat-mdk shadowcat-mdk changed the title #Angular: App updates during login procedure and log in details are lost and have to be re-entered #ClientSide: App updates during login procedure and log in details are lost and have to be re-entered Mar 5, 2024
@shadowcat-mdk shadowcat-mdk changed the title #ClientSide: App updates during login procedure and log in details are lost and have to be re-entered #Angular: App updates during login procedure and log in details are lost and have to be re-entered Mar 5, 2024
@shadowcat-mdk shadowcat-mdk modified the milestones: Freyja, Gleipnir Mar 5, 2024
@gtandersen gtandersen modified the milestones: Gleipnir, Jörð May 7, 2024
@gtandersen
Copy link
Contributor

We could also show the update prompt in the "snackbar" where it's less intrusive.

@gtandersen gtandersen modified the milestones: Jörð, Loki Aug 9, 2024
@gtandersen gtandersen modified the milestones: Loki, Magni Sep 29, 2024
@gtandersen gtandersen modified the milestones: Magni, Rán Nov 5, 2024
castaway added a commit to shadow-dot-cat/runbox7 that referenced this issue Feb 17, 2025
@castaway
fix(updates): Check immediately for updates, and then not for 5 mins
9b43365 
Fixes runbox#704
castaway added a commit to shadow-dot-cat/runbox7 that referenced this issue Feb 17, 2025
@castaway
fix(updates): Use isStable to check as soon as possible for updates
cb198f6 
Fixes: runbox#704
castaway added a commit to shadow-dot-cat/runbox7 that referenced this issue Feb 17, 2025
@castaway
feat(updates): Moves application update dialog to non-modal snackbar
0706f1d 
Fixes: runbox#704
castaway added a commit to shadow-dot-cat/runbox7 that referenced this issue Feb 19, 2025
@castaway
fix(updates): Check immediately for updates, and then not for 5 mins
09068cb 
Fixes runbox#704
castaway added a commit to shadow-dot-cat/runbox7 that referenced this issue Feb 19, 2025
@castaway
fix(updates): Use isStable to check as soon as possible for updates
7a47aa0 
Fixes: runbox#704
castaway added a commit to shadow-dot-cat/runbox7 that referenced this issue Feb 19, 2025
@castaway
feat(updates): Moves application update dialog to non-modal snackbar
f828a50 
Fixes: runbox#704
castaway added a commit that referenced this issue Feb 20, 2025
@castaway
feat(updates): Moves application update dialog to non-modal snackbar
bd60c7a 
Fixes: #704
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@castaway castaway

Labels
enhancement New feature or request P2-high
Projects
None yet
Milestone
Rán
Development

Successfully merging a pull request may close this issue.

Castaway/704 check for updates immediately runbox/runbox7
4 participants
@castaway @shadowcat-mdk @gtandersen @runboxdave