Castaway/704 check for updates immediately #1297
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not entirely sure this works yet - isStable apparently only gets stable if no polling things are started/happening, so may need to check those too. This can be improved by using activateUpdate instead of window.reload, and then subscribing to "unrecoverable state" to reload in case of issues, see https://v11.angular.io/guide/service-worker-communications |
castaway
force-pushed
the
castaway/704_check_for_updates_immediately
branch
from
cef5106 to
f828a50
Compare
isStable doesn't happen in an app that starts scheduled tasks immediately
castaway
force-pushed
the
castaway/704_check_for_updates_immediately
branch
from
f828a50 to
1c0b6b1
Compare
shadowbas
reviewed
Feb 20, 2025
| 'current': | ||
| {'hash':'blah', 'appData':{'build_epoch':'XX'}}, | ||
| 'available': | ||
| {'hash':'blah', 'appData':{'commit':'test', 'build_time': 'time', 'build_epoch':'XX'}}, |
There was a problem hiding this comment.
The blah seems a bit strange. What is the reason?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #704 .. or improves anyway