Updates bulk messages PR, adding index working (less data passing) improvements #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a "contact support" component, since it's a UI pattern we repeat a lot.
shadowbas
reviewed
Jan 6, 2025
castaway
force-pushed
the
castaway/bulk_message_api_2
branch
from
e299c16 to
d852bad
Compare
shadowbas
reviewed
Jan 6, 2025
shadowbas
reviewed
Jan 6, 2025
shadowbas
reviewed
Jan 6, 2025
castaway
force-pushed
the
castaway/bulk_message_api_2
branch
from
d852bad to
798ed9e
Compare
castaway
force-pushed
the
castaway/bulk_message_api_2
branch
from
798ed9e to
8c5c304
Compare
shadowbas
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On canvas update, fetch all in-view message contents at once (instead of one request per message), .. if not already in the cache. After fetching, update the index (to add the message contents to the index), for all the fetched messages at once, making less data exchanges between the two threads.
This should mean less busy threads and more prompt actions for users