Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(account): Split renewals page into active and expired products #927

Open
wants to merge 286 commits into
base: master
Choose a base branch
from

Conversation

tadzik
Copy link
Contributor

@tadzik tadzik commented Mar 12, 2021

This should make it easier to tell the ones the user cares about from the ones that are long gone, especially in older accounts.

Looks like this:

active

expired

The order of importance is: the soonest-expiring first on the Active tab, latest-expired first on the Expired tab.

I do have a problem with the naming though. The Active/Expired naming makes sense to me, but we call the entire page Active products, which now makes it awkward. This was a problem with variable naming in the source as well, which I noted down in the comment. @davidbowdley suggested renaming the entire page to Products – on the other hand, the whole Account section is called "Account products", referring to both available and, ugh, active-and-expired ones. Ideas?

@gtandersen
Copy link
Contributor

Nice work @tadzik!

One solution (as discussed elsewhere) could be to rename the section to Subscriptions and remove the concept of products altogether.

@castaway
Copy link
Contributor

castaway commented Mar 23, 2021

Not sure you changed this one, but the titles/menu entries for "Main Account Subscriptions/Plans" are confusing:

image

Also if its also called subscriptions that conflicts with the suggestion for the "products" page. .

Right, having never actually looked at these pages, my thoughts:

  • I'd expect the main/first page I arrive at to be the one listing my current things, (eg the active/expired page with the renewal button) - could be called "Your Plan" (or "Your subscriptions")
  • The current first one (Main account plan), which seems to offer me more things to buy, is effectively a "Pricing" page, so I'd call it that, or something obvious like "Buy/Upgrade more plans"
  • Add-ons page seems ok (tho paying for aliases? er.. don't we just create those in identities?)
  • I feel like Transactions could (now) be another tab on the Active/Expired page ?
  • Card details could almost be another tab on that page, if that doesn't make it too busy

@runboxdave
Copy link

It's quite important that recently expired products should still appear under "Active". Perhaps for 1 month? Then they can move to Expired. They shouldn't appear in both places during this time.

@gtandersen
Copy link
Contributor

Agree that we could be even more consistent wrt naming here.

See also #424 (comment) for a discussion about naming (where Products can be replaced with Subscriptions).

Note that aliases need to remain a product/quota at least for Runbox addresses since aliases reserve addresses that are in demand.

I think Transactions can remain its own menu item and page since it's an important record a customer might expect to find easily.

@runboxdave
Copy link

runboxdave commented Apr 1, 2021

Page titles need updating.

We should look at the URLs too as they may need changing. You go up /upgrades to downgrade/change your plan and /renewals to see your active products while /credit-cards may also be debit cards (which are by far more common).

Sub-accounts are probably the most commonly purchased add-on so should be listed first on the add-ons page.

There are too many clicks required (four I believe from the mail webmail screen) before you see a product to purchase.

@gtandersen
Copy link
Contributor

I like that each page isn't too long as it makes them easier to navigate, but perhaps we could merge the two pages Main Account Plans and Add-ons & Sub-Accounts since they are closely related and the product cards could possibly be made smaller (and fewer), thusly:

  1. Main account subscriptions
  2. Sub-account subscriptions
  3. Main account add-ons (these can probably be phased out over some time)

And I agree that it would be sensible to show existing products/subscriptions first in the menu, but if we want separate pages for Transactions and Card Details these would logically come next and put Main Account Plans and Add-ons & Sub-Accounts last.

So, how about the following menu (with the existing titles in parenthesis and proposed URL thereafter):

Subscriptions & Payments

  • Plans & Upgrades (Main Account Plans + Add-ons & Sub-Accounts): /app/account/plans
  • Your Subscriptions (Active products & Renewals): /app/account/subscriptions
  • Your Payments (Transactions): /app/account/payments
  • Your Cards (Card Details): /app/account/cards

Alternatively, if we want to list existing subscriptions first, we could use this menu:

Subscriptions & Payments

  • Your Subscriptions (Active products & Renewals): /app/account/subscriptions
  • Plans & Upgrades (Main Account Plans + Add-ons & Sub-Accounts): /app/account/plans
  • Payment History (Transactions): /app/account/payments
  • Payment Cards (Card Details): /app/account/cards

By the way, I think we decided to move away from tabs due to issues on smaller screens, so Active Products and Expired products could perhaps be vertical sections instead? :)

kvviecien and others added 29 commits September 8, 2021 21:24
fix(mailviewer): Remove big icons from print view
…creens

fix(app): Fit message list option menu on small mobile screens
…provements

Piratefinn/gh 1033/mailheader improvements
…ead_filter_non_index

Castaway/979 preview unread filter non index
feat(app-passwords): use monospaced fonts for app passwords listing
…5.7.1

build(deps): bump tinymce from 5.6.2 to 5.7.1
fix(mailviewer): Remove big icons from print view (again)
…ead_counters

fix(foldercounts): Update counts on index refresh, only when changed
…fferentiation

fix(identities): Ensure identities can be told apart
…_update

fix(identities): Only display "origin" field for RMM6 folders
@castaway
Copy link
Contributor

Gah, I rebased this which made it more complicated ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants