-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(account): Split renewals page into active and expired products #927
base: master
Are you sure you want to change the base?
Conversation
Nice work @tadzik! One solution (as discussed elsewhere) could be to rename the section to Subscriptions and remove the concept of products altogether. |
Not sure you changed this one, but the titles/menu entries for "Main Account Subscriptions/Plans" are confusing: Also if its also called subscriptions that conflicts with the suggestion for the "products" page. . Right, having never actually looked at these pages, my thoughts:
|
feat(settings): Add content to the main Settings page
It's quite important that recently expired products should still appear under "Active". Perhaps for 1 month? Then they can move to Expired. They shouldn't appear in both places during this time. |
Agree that we could be even more consistent wrt naming here. See also #424 (comment) for a discussion about naming (where Products can be replaced with Subscriptions). Note that aliases need to remain a product/quota at least for Runbox addresses since aliases reserve addresses that are in demand. I think Transactions can remain its own menu item and page since it's an important record a customer might expect to find easily. |
feat(app): Cache message contents in indexedDB
Page titles need updating. We should look at the URLs too as they may need changing. You go up /upgrades to downgrade/change your plan and /renewals to see your active products while /credit-cards may also be debit cards (which are by far more common). Sub-accounts are probably the most commonly purchased add-on so should be listed first on the add-ons page. There are too many clicks required (four I believe from the mail webmail screen) before you see a product to purchase. |
I like that each page isn't too long as it makes them easier to navigate, but perhaps we could merge the two pages Main Account Plans and Add-ons & Sub-Accounts since they are closely related and the product cards could possibly be made smaller (and fewer), thusly:
And I agree that it would be sensible to show existing products/subscriptions first in the menu, but if we want separate pages for Transactions and Card Details these would logically come next and put Main Account Plans and Add-ons & Sub-Accounts last. So, how about the following menu (with the existing titles in parenthesis and proposed URL thereafter): Subscriptions & Payments
Alternatively, if we want to list existing subscriptions first, we could use this menu: Subscriptions & Payments
By the way, I think we decided to move away from tabs due to issues on smaller screens, so Active Products and Expired products could perhaps be vertical sections instead? :) |
…2FA in Runbox 7 issue 411
Update us to Angular 11
fix(mailviewer): Remove big icons from print view
fix(login) Allow normal text in OTP input
…creens fix(app): Fit message list option menu on small mobile screens
…provements Piratefinn/gh 1033/mailheader improvements
…ead_filter_non_index Castaway/979 preview unread filter non index
feat(app-passwords): use monospaced fonts for app passwords listing
…5.7.1 build(deps): bump tinymce from 5.6.2 to 5.7.1
Update issue templates
fix(mailviewer): Remove big icons from print view (again)
…ead_counters fix(foldercounts): Update counts on index refresh, only when changed
…fferentiation fix(identities): Ensure identities can be told apart
…rors Castaway/message load errors
…_update fix(identities): Only display "origin" field for RMM6 folders
…7 into tadzik/split-renewals-page
Gah, I rebased this which made it more complicated .. |
This should make it easier to tell the ones the user cares about from the ones that are long gone, especially in older accounts.
Looks like this:
The order of importance is: the soonest-expiring first on the Active tab, latest-expired first on the Expired tab.
I do have a problem with the naming though. The Active/Expired naming makes sense to me, but we call the entire page Active products, which now makes it awkward. This was a problem with variable naming in the source as well, which I noted down in the comment. @davidbowdley suggested renaming the entire page to Products – on the other hand, the whole Account section is called "Account products", referring to both available and, ugh, active-and-expired ones. Ideas?