Refactor allowed syntax checks for attributes#4011
Closed
Scott-Guest wants to merge 2 commits intodevelopfrom
Closed
Refactor allowed syntax checks for attributes#4011Scott-Guest wants to merge 2 commits intodevelopfrom
Scott-Guest wants to merge 2 commits intodevelopfrom
Conversation
aad6013 to
3719adb
Compare
Contributor
Author
|
Parking this until we can move CheckAtt to immediately after parsing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3982
Previously, each attribute specified an allowed set of
Class[_]s where that attribute may occur. However, both a cell and a non-cell are justProductions, so noClass[_]restriction is sufficient to distinguish cells.This PR then refactors to instead have an allowed set of
Att.Syntaxtypes, each with aisA(term: AnyRef): Booleanmethod to check membership.In process, we also:
label(_)to rules, claims, contexts, and context aliases rather than allowing it on any sentencegroup(_)to productionscell,cellName,exit,stream,multiplicity, andtypeto cells