-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single Body
Instance
s
#505
Single Body
Instance
s
#505
Conversation
Stable MIR JSON on working branch.
…tion/mir-semantics into dc/single-body-instances
…tion/mir-semantics into dc/single-body-instances
After the updated to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please pretty-print the checked-in JSON (to get a chance to read a small diff)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100% I should of done that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto, please reformat using jq. Something like
for file in $(find ...exec-smir -name \*smir.json); do echo $file; jq . $file > $file.pretty && mv $file.pretty $file; done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the tab size was consistent with all of these. They are all formatted with jq .
now so hopefully things are consistent from now on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite possibly I used vscode's formatter on some of them before...
Stable MIR JSON PR#60 removes the error where we thought we had to find the
Body
for promoted items. This is reflecting that change by removing the list ofBody
and changing it to anmaybeBody
forMonoItem::Fn
since sometimes aBody
is not present