Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single Body Instances #505

Merged
merged 15 commits into from
Mar 25, 2025
Merged

Conversation

dkcumming
Copy link
Collaborator

Stable MIR JSON PR#60 removes the error where we thought we had to find the Body for promoted items. This is reflecting that change by removing the list of Body and changing it to an maybeBody for MonoItem::Fn since sometimes a Body is not present

@dkcumming dkcumming self-assigned this Mar 24, 2025
@dkcumming
Copy link
Collaborator Author

After the updated to stable-mir-json I will pull that into the submodule, but I think we can review it pointing to the branch for now

@dkcumming dkcumming requested review from jberthold and gtrepta March 25, 2025 08:17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please pretty-print the checked-in JSON (to get a chance to read a small diff)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% I should of done that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto, please reformat using jq. Something like
for file in $(find ...exec-smir -name \*smir.json); do echo $file; jq . $file > $file.pretty && mv $file.pretty $file; done

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the tab size was consistent with all of these. They are all formatted with jq . now so hopefully things are consistent from now on

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite possibly I used vscode's formatter on some of them before...

@automergerpr-permission-manager automergerpr-permission-manager bot merged commit ecdca8b into master Mar 25, 2025
5 checks passed
@automergerpr-permission-manager automergerpr-permission-manager bot deleted the dc/single-body-instances branch March 25, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants