Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.2でSetが組み込みライブラリになったことに対応 #2769

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kyanagi
Copy link
Contributor

@kyanagi kyanagi commented Dec 29, 2022

  • set.rd_builtin/Set にコピーし、
    • require 'set' を削除
    • 3.2未満に関する記述を削除
  • set.rd#@until 3.2 指定
  • _builtin/Set#@since 3.2 指定
  • Enumerable#to_set#@since 3.2 指定で Enumerable に追加

としてみました。

@znz
Copy link
Member

znz commented Jan 12, 2023

set はまだ default gem で本体組み込みの機能ではない(https://stdgems.org/set/)ので、https://github.com/ruby/ruby/blob/617b3f697d95c6e9aaf585e18a2d1c96b94cab99/prelude.rb で同じように autoload っぽい感じになっている pp なども含めて _builtin 以下にするかどうかは考えた方が良さそうです。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants