Skip to content

Conversation

@nyonson
Copy link
Collaborator

@nyonson nyonson commented Dec 16, 2025

Initially only supporting the dynamic listing of targets, but that might still be super helpful for the CI jobs. The command is following a similar style of integration where it is assuming some sort of fuzz crate in the workspace.

Related to #5

@nyonson nyonson changed the title cargo-rbmt: add fuzz subcommand Add fuzz subcommand Dec 16, 2025
use xshell::Shell;

/// Default package name for fuzz targets.
const FUZZ_PACKAGE: &str = "bitcoin-fuzz";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why we have to use bitcoin-fuzz as the package name in rust-bitcoin, would it be easier (in future perhaps) to change it and use fuzz as the default here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, probably. We are the only users so easy to roll out. I was just taking the path of least resistance for now.

Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 743fab9

@tcharding
Copy link
Member

I acke'd because if it works it works. But did you try it out on rust-bitcoin? I was surprised to not see the path field handled explicitly.

E.g

[[bin]]
name = "bitcoin_arbitrary_block"
path = "fuzz_targets/bitcoin/arbitrary_block.rs"

@nyonson
Copy link
Collaborator Author

nyonson commented Dec 17, 2025

I acke'd because if it works it works. But did you try it out on rust-bitcoin? I was surprised to not see the path field handled explicitly.

Yea, I am running it on rust-bitcoin and it prints out the targets (e.g. bitcoin_arbitrary_block), is it throwing an error for you?

@tcharding
Copy link
Member

tcharding commented Dec 17, 2025

No I didn't test this one, was lazy and just asked you. 'trust don't verify', right?

@nyonson
Copy link
Collaborator Author

nyonson commented Dec 17, 2025

2ef2083: rebased

@apoelstra
Copy link
Member

BTW do we expect this crate to be formatted? It's pretty close to being so.

@nyonson
Copy link
Collaborator Author

nyonson commented Dec 18, 2025

BTW do we expect this crate to be formatted? It's pretty close to being so.

I am planning on adding the same lint and fmt rules as rust-bitcoin with #54

Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2ef2083

Initially only supporting the dynamic listing of targets.
@nyonson
Copy link
Collaborator Author

nyonson commented Dec 18, 2025

9a24e67: rebased and switched the default package name to just fuzz.

Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9a24e67

@tcharding tcharding merged commit 10c544f into rust-bitcoin:master Dec 18, 2025
2 checks passed
@apoelstra
Copy link
Member

utACK 9a24e67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants