Skip to content

Conversation

@nyonson
Copy link
Collaborator

@nyonson nyonson commented Dec 18, 2025

Without the releases dependency graph, pretty easy to dogfood min and recent version testing. Also easier to adopt rust-bitcion's lint and format rules. I kept it a workspace even though it only has one package to dogfood the slightly more complex case. Plus, might add some packages in the future.

Closes #54

@nyonson nyonson changed the title Remove releases and introduce min version testing Remove releases, introduce min version testing, match rust-bitcoin lint and fmt Dec 18, 2025
Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 04f8b0a

@tcharding tcharding merged commit 3fe854d into rust-bitcoin:master Dec 18, 2025
2 checks passed
@apoelstra
Copy link
Member

In e195b5a:

This fails to restore the existing lockfile if LockFile::Minimal.derive or LockFile::Recent.derive fail. We should use a drop guard here to ensure that restore_existing is run no matter how the function exits (or we should manually call restore_existing in each error path, which in this case might be fewer LOC).

@apoelstra
Copy link
Member

We could change backup_existing to return a handle which calls restore_existing on Drop.

@apoelstra
Copy link
Member

Otherwise 04f8b0a looks good. We should add avoid-breaking-exported-api = false to clippy.toml here because there is no public API we're exposing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rargo-rbmt: Consider using clippy config from rust-bitcoin

3 participants