Whitelist API breaks

[nyonson]

Opening this as a draft because it showing some short comings using the cargo-public-api crate. It uses rustdocs to generate the api snapshot files and diffs, but this gives it an unexpected (to me) dependency on the nightly toolchain version: https://github.com/cargo-public-api/cargo-public-api?tab=readme-ov-file#compatibility-matrix

So to use a modern nightly toolchain, need to up to 0.50 which bumps the MSRV of rbmt. That isn't all that terrible, this is just a dev tool after all. But I am curious how painful it will be to keep in-step with nightly versions.

Related to #58

[nyonson]

Found that the public-api crate exposes the min version it needs for the nightly toolchain, MINIMUM_NIGHTLY_RUST_VERSION, so can at least have rbmt fail in a helpful way.

[apoelstra]

I'm a little bit confused -- the code here bumps the MSRV to 1.85. But are you saying that the actual MSRV is "nightly"? What happens if you try to compile with 1.85?

[nyonson]

I'm a little bit confused -- the code here bumps the MSRV to 1.85. But are you saying that the actual MSRV is "nightly"? What happens if you try to compile with 1.85?

Sorry, little MIA right now through the holidays. But I think I was over thinking this one and it's simpler to just say "it has an MSRV on a nightly version of at least X based on its version". I'll dig into it more next week though, just making a note for now.

[nyonson]

Closing this to re-think the public-api crate usage. Its diff features sound cool, but appears to struggle with some semi-advance rust features like associated types. So maybe not ready for anything beyond just generating the API files? Gotta understand it better.