Skip to content

Add example with postgres and add rusqlite in new directory #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jonatasoli
Copy link

In the examples directory, I add the rusqlite example for the new directory with name rusqlite

I added an example with PostgreSQL, with tokyo client and executed it with a docker file.

Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jonatas, and thanks for this and sorry for the delay in reviewing it!
Left some comments

.run_async(&mut client)
.await?;

println!("Migrations apllied with success:");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
println!("Migrations apllied with success:");
println!("Migrations applied with success:");

@@ -0,0 +1,29 @@
use tokio_postgres::NoTls;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems equal to the postgres_docker_sql example, is there any value in adding this as well? I think we can just have the docker one with a README.md explaining how to run it in the main examples dir

@@ -0,0 +1,8 @@
CREATE TABLE transactions (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of moving the existing examples to the rusqlite example dir, can we have them at the main examples level and use them in this example as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants