secure routing API for NVIC now takes exclusive reference - #674
Merged
jonathanpallant merged 1 commit intoJul 25, 2026
Merged
Conversation
robamu
requested review from
Copilot and
jonathanpallant
and removed request for
Copilot
July 24, 2026 17:01
Merged
Contributor
|
Yes these methods should take &mut - good catch |
thejpster
approved these changes
Jul 24, 2026
robamu
changed the title
jonathanpallant
approved these changes
Jul 25, 2026
jonathanpallant
deleted the
nvic-secure-routers-now-take-exclusive-ownership
branch
July 25, 2026 08:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
these methods do a non-atomic operation because they modify the register. In the
set_prioritymethod which also does a register modification, the method takes exclusive reference by taking &mut self. maybe we should do the same here? if not, we should either update the safety note, or updateset_priorityto be consistent.