-
Notifications
You must be signed in to change notification settings - Fork 59
Add a macro to make initialization easier #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6bca433
to
6335bb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me, thanks! Just a bit of nitpicks and it should be mergable.
9951db6
to
080581e
Compare
@zeenix I have made improvements based on the suggestions, and I added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@JalonWong I'll merge soon but I want to first give others a chance to have a look. CC @adamgreig @sgued |
My only thought is that people are likely to want to configure where the backing store for the heap is located in memory using
|
How about a combination of these two: we add the optional argument for the linker section and if people need to add other attributes, they just don't use the macro? |
6d4171b
to
1e17f59
Compare
@zeenix @adamgreig If someone want to use |
f447854
to
d47bd8a
Compare
f5ba156
to
b3afee2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry but still some things to do. Thank you for your patience and hard work on this so far. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A tiny nit and then we're good to merge. 👍
Co-authored-by: Zeeshan Ali Khan <[email protected]>
No description provided.