Skip to content

add: Mock SPI errors#131

Merged
ryankurte merged 2 commits intorust-embedded:mainfrom
2bndy5:spi-err
Mar 11, 2026
Merged

add: Mock SPI errors#131
ryankurte merged 2 commits intorust-embedded:mainfrom
2bndy5:spi-err

Conversation

@2bndy5
Copy link
Contributor

@2bndy5 2bndy5 commented Apr 25, 2025

resolves #128

Please review diligently as I'm not overly familiar with this crate's code.

@2bndy5 2bndy5 changed the title Mock SPI errors add: Mock SPI errors Apr 25, 2025
@benjaminschlegel87
Copy link

I stumbled across the same problem today and was quite pleased to this was already implemented. As a disclaimer: I got general embedded experience but in terms of idomatic rust I am quite a beginner. Still I reviewed your implementation and the tests. From my POV this looks good and I would have implemented it equally. Would like to see this upstream

Copy link
Contributor

@simonsso simonsso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, same kind of implementations as used in I2C.

@simonsso
Copy link
Contributor

Ok then all we need is @dbrgn to get some time and merge this.

@2bndy5
Copy link
Contributor Author

2bndy5 commented Oct 22, 2025

It's been pending admin review for over half a year. I'm not holding my breathe. Instead, I've been using this from my fork's dev branch (cherry picked commits from this branch and another PR also pending review).

@simonsso
Copy link
Contributor

It's been pending admin review for over half a year. I'm not holding my breathe. Instead, I've been using this from my fork's dev branch (cherry picked commits from this branch and another PR also pending review).

Yes I saw that.

@dbrgn
Copy link
Collaborator

dbrgn commented Dec 30, 2025

It's been pending admin review for over half a year. I'm not holding my breathe. Instead, I've been using this from my fork's dev branch (cherry picked commits from this branch and another PR also pending review).

Yeah, sorry, I haven't had the time to review so far. I will try again to get this project adopted by rust-embedded, in the hope that this will improve things.

@simonsso
Copy link
Contributor

@dbrgn thanks for your hard work, and thanks for adopting your baby. Hope we can gen some help from the @rust-embedded team now with the PRs. Please let us know if there is anything we can do to help.

@ryankurte
Copy link
Contributor

looooks good to me, thanks folks!

@ryankurte ryankurte merged commit c827e70 into rust-embedded:main Mar 11, 2026
3 checks passed
@2bndy5
Copy link
Contributor Author

2bndy5 commented Mar 11, 2026

I gotta say, I'm very glad someone is willing to carry this project forward! ❤️

@2bndy5 2bndy5 deleted the spi-err branch March 13, 2026 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add with_error() for SPI Transaction

5 participants