De-monomorphize spsc consumer and producer #571
+133
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
sosthene-nitrokey
force-pushed
the
spcs-demonomorphize
branch
2 times, most recently
from
970035f to
e4c5b81
Compare
|
This is a breaking change, but if we yank 0.9.0 as I suggest to do in #568 , it would be nice to have it in the next release. |
sosthene-nitrokey
force-pushed
the
spcs-demonomorphize
branch
2 times, most recently
from
9790bcf to
53bb179
Compare
This needs a workaround for the `const` use case however
sosthene-nitrokey
force-pushed
the
spcs-demonomorphize
branch
from
53bb179 to
e282e0a
Compare
| @@ -464,8 +597,8 @@ impl<T, S: Storage> QueueInner<T, S> { | |||
| /// consumer.dequeue().unwrap(); | |||
| /// } | |||
| /// ``` | |||
| pub const fn split(&mut self) -> (ProducerInner<'_, T, S>, ConsumerInner<'_, T, S>) { | |||
| (ProducerInner { rb: self }, ConsumerInner { rb: self }) | |||
| pub const fn split_const(&mut self) -> (Producer<'_, T>, Consumer<'_, T>) { | |||
There was a problem hiding this comment.
The example here doesn't actually call this on QueueView. In fact, I don't think this makes sense on QueueView, since we first need a static Queue anyways, so there is no point in going through a QueueView to split it.
There was a problem hiding this comment.
It makes sense to have it available for QueueView if you have some const functions that does some initialization, which you use to build the statics.
I updated the doc to use the View.
sosthene-nitrokey
force-pushed
the
spcs-demonomorphize
branch
from
05ddff8 to
160870e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs a workaround for the
constuse case however