Skip to content

Fix memory layout of UnionNode<T> in pool module #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2025
Merged

Fix memory layout of UnionNode<T> in pool module #606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c70d081
Fixed memory layout of UnionNode in pool module
pc-for-science Sep 8, 2025
66dab53
Added missing CHANGELOG entry
pc-for-science Sep 8, 2025
ca2368d
Update CHANGELOG.md to more concise description
Mortano Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

- CI now uses flags specified in `Cargo.toml` for `rustdoc` tests.
- Fixed clippy lints.
- Fixed the memory layout of the internal `UnionNode<T>` type, fixing possible Undefined Behaviour.

### Removed

Expand Down
1 change: 1 addition & 0 deletions src/pool/treiber.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ pub trait Node: Sized {
fn next_mut(&mut self) -> &mut AtomicPtr<Self>;
}

#[repr(C)]
pub union UnionNode<T> {
next: ManuallyDrop<AtomicPtr<UnionNode<T>>>,
pub data: ManuallyDrop<T>,
Expand Down