Skip to content

Fix cc wrappers (revert #197) #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fbeutel
Copy link

@fbeutel fbeutel commented May 8, 2025

If I'm not mistaken, the changes made in pull request #197 break some rust build scripts.

The behavior as it originally was should have been correct, as it defines

CC="${WRAPPER_DIR}/cc-native-wrapper.sh"    # this is used when building on the host, as long as `HOST_CC` is not defined, and therefore it should point to cc-native-wrapper.sh
TARGET_CC="${WRAPPER_DIR}/cc-wrapper.sh"

According to the cc docs, TARGET_CC takes precedence over CC when cross-compiling to the target, and otherwise CC is being used.

In addition, the original pull request defined the variable BUILD_CC, but that is meaningless for the cc crate (Yocto defines such a variable, but cc only looks for HOST_CC and CC when compiling for the host).

I think this should also fix #204

I'm not sure what the original problem was which pull request #197 tried to solve, but maybe there was just no adequate gcc installed on the host system?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: Can no longer build libsqlite3-sys
1 participant