Add GitHub Action for newsletter creation#1464
Merged
AngelOnFira merged 9 commits intorust-gamedev:sourcefrom Apr 9, 2024
Merged
Add GitHub Action for newsletter creation#1464AngelOnFira merged 9 commits intorust-gamedev:sourcefrom
AngelOnFira merged 9 commits intorust-gamedev:sourcefrom
Conversation
janhohenheim
changed the title
ThierryBerger
approved these changes
Mar 25, 2024
AngelOnFira
requested changes
Mar 31, 2024
Member
AngelOnFira
left a comment
AngelOnFira
left a comment
There was a problem hiding this comment.
A few small changes, but looks good to me. I don't mind merging it once they're resolved, then resolving any other issues after it creates the first issue 👍🏻
newsletter-template.md
Outdated
| title = "This Month in Rust GameDev #{TODO} - {TODO} {TODO}" | ||
| title = "This Month in Rust GameDev #{{ NEWSLETTER_COUNTER }} - {{ NEWSLETTER_MONTH }} {{ NEWSLETTER_YEAR }}" | ||
| transparent = true | ||
| date = TODO |
Member
There was a problem hiding this comment.
Should this be templated too?
Collaborator
Author
There was a problem hiding this comment.
I left this blank because it's supposed to be the date the post is actually published. I could fill in the deadline if you want (3rd of the next month).
Member
There was a problem hiding this comment.
Normally we set a date that would be nice to have it done by (say the 1st if we really are ahead of timelines), and update once it does actually get published. Also, it fails building the site with just TODO 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.