fix(install): check if git url contains a rev #15489
Conversation
rustbot
added
A-cli
src/bin/cargo/commands/install.rs
Outdated
| if url.contains('#') { | ||
| return Err(anyhow::format_err!( | ||
| "invalid git url to install from\n\n\ | ||
| help: use `--rev <SHA>` to specify a commit" | ||
| ) | ||
| .into()); | ||
| } | ||
|
|
||
| let url = url.into_url()?; |
There was a problem hiding this comment.
Should this check be done on the parsed URL, rather than on the string?
There was a problem hiding this comment.
Thanks, yeah. That makes a lot of sense.
src/bin/cargo/commands/install.rs
Outdated
| if url.contains('#') { | ||
| return Err(anyhow::format_err!( | ||
| "invalid git url to install from\n\n\ | ||
| help: use `--rev <SHA>` to specify a commit" | ||
| ) | ||
| .into()); | ||
| } | ||
|
|
There was a problem hiding this comment.
Is this definitively a bad URL or should this be a hint on the existing error?
There was a problem hiding this comment.
I think it's definitely a bad URL, yes.
From the github page:
I can't think of a valid git url with a # besides the rev.
There was a problem hiding this comment.
Cargo supports more than Github. The question would be more about the git protocol and what is expected around it as we could be turning a success case into an error case.
There was a problem hiding this comment.
From what I'm seeing here, other git servers should be the same.
return error if the git url contains a # and hint user to use --rev
dawedawe
force-pushed
the
check_rev_in_git_url
branch
from
552440b to
dcc8cef
Compare
Check if the git url contains a '#' which is likely a sign for the user's desire to specify a rev. Give hint to use
--revFixes #15336