Skip to content

feat(index): Stabilize pubtime #16372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
epage wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(index): Stabilize pubtime #16372

epage wants to merge 1 commit into from
+27 −12

Conversation

@epage
Copy link
Contributor

@epage epage commented Dec 10, 2025

What does this PR try to resolve?

Unblocks #15973, #5221

Closes #15491
Closes #16270

How to test and review this PR?

@epage epage added the T-cargo Team: Cargo label Dec 10, 2025
@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 10, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 10, 2025

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

epage
epage commented Dec 10, 2025
View reviewed changes
src/doc/src/reference/unstable.md

## pubtime

The `pubtime` index field has been stabilized in Rust 1.94.0.
Copy link
Contributor Author

@epage epage Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have this set for 1.94

@epage
Copy link
Contributor Author

epage commented Dec 10, 2025

@rfcbot fcp merge T-cargo

@rust-rfcbot
Copy link
Collaborator

rust-rfcbot commented Dec 10, 2025 •
edited by Muscraft
Loading

Team member @epage has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rust-rfcbot rust-rfcbot added proposed-final-comment-period An FCP proposal has started, but not yet signed off. disposition-merge FCP with intent to merge labels Dec 10, 2025
epage
epage commented Dec 10, 2025
View reviewed changes
crates/cargo-util-schemas/index.schema.json
Copy link
Contributor Author

@epage epage Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge is blocked on T-crates.io informing us that they have made a decision

@epage epage mentioned this pull request Dec 10, 2025
Open
3 tasks
weihanglo
weihanglo approved these changes Dec 10, 2025
View reviewed changes
0xPoe
0xPoe approved these changes Dec 10, 2025
View reviewed changes
Copy link
Member

@0xPoe 0xPoe left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :shipit:

View changes since this review

@rustbot

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Dec 12, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@ehuss ehuss moved this to FCP merge in Cargo status tracker Dec 15, 2025
@rust-rfcbot rust-rfcbot added final-comment-period FCP — a period for last comments before action is taken and removed proposed-final-comment-period An FCP proposal has started, but not yet signed off. labels Dec 16, 2025
@rust-rfcbot
Copy link
Collaborator

rust-rfcbot commented Dec 16, 2025

🔔 This is now entering its final comment period, as per the review above. 🔔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weihanglo weihanglo weihanglo approved these changes

@0xPoe 0xPoe 0xPoe approved these changes

Assignees

@weihanglo weihanglo

Labels

A-documenting-cargo-itself Area: Cargo's documentation disposition-merge FCP with intent to merge final-comment-period FCP — a period for last comments before action is taken S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cargo Team: Cargo

Projects

Cargo status tracker
Status: FCP merge

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tracking Issue for _pubtime_ registry-index: Add release date to Index Format

5 participants

@epage @rustbot @rust-rfcbot @weihanglo @0xPoe