Skip to content

refactor(context): normalize in homedir instead#17222

Open
hirehamir wants to merge 1 commit into
rust-lang:masterfrom
hirehamir:refactor/normalize-in-homedir
Open

refactor(context): normalize in homedir instead#17222
hirehamir wants to merge 1 commit into
rust-lang:masterfrom
hirehamir:refactor/normalize-in-homedir

Conversation

@hirehamir

Copy link
Copy Markdown
Contributor

What Does This PR Try to Resolve?

This is a follow-up to #17204.

That fix normalized inside read_packages.

As noted in review, Cargo prefers to normalize at the exterior and assume interiors are clean.

This change moves the normalize_path to homedir, and removes the interior normalization.

How to Test and Review This PR?

  • config_symlink_home_duplicate_load and install_git_with_symlink_home pass. Symlink handling appears undisturbed.
  • no_duplicate_package_warning_with_dotdot_cargo_home (added in fix(source): incorrect duplicate package warning #17204) still passes. The exterior placement fixes the same issue.
cargo test --test testsuite -- no_duplicate_package_warning_with_dotdot_cargo_home config_symlink_home_duplicate_load install_git_with_symlink_home

@rustbot rustbot added A-configuration Area: cargo config files and env vars S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2026
@rustbot

rustbot commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @epage, @weihanglo
  • @epage, @weihanglo expanded to epage, weihanglo
  • Random selection from epage, weihanglo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-configuration Area: cargo config files and env vars S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants