Skip to content

A note that build.warnings and CARGO_BUILD_WARNINGS don't apply to MIRI#17224

Open
peter-lyons-kehl wants to merge 1 commit into
rust-lang:masterfrom
peter-lyons-kehl:CARGO_BUILD_WARNINGS_not_for_MIRI
Open

A note that build.warnings and CARGO_BUILD_WARNINGS don't apply to MIRI#17224
peter-lyons-kehl wants to merge 1 commit into
rust-lang:masterfrom
peter-lyons-kehl:CARGO_BUILD_WARNINGS_not_for_MIRI

Conversation

@peter-lyons-kehl

Copy link
Copy Markdown

Thanks for the pull request 🎉!
Please read the contribution guide: https://doc.crates.io/contrib/.

What does this PR try to resolve?

rust-lang/miri#5202

@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2026
@rustbot

rustbot commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @epage (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @epage, @weihanglo
  • @epage, @weihanglo expanded to epage, weihanglo
  • Random selection from epage, weihanglo

@epage

epage commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Does this belong in Cargo's docs or in miris'?

cargo miri is an unstable command and I would consider this a bug on their side (even if they consider it wontfix)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants