Disable aarch64 assembly if target_abi = "softfloat"
#905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The target `aarch64-unknown-none-softfloat` still sets the `neon` target feature, so the assembly implementations are incorrectly being enabled. Update gates to differentiate the `softfloat` ABI.
tgross35
force-pushed
the
aarch64-softfloat-no-asm
branch
from
419c848 to
6e892aa
Compare
|
Nevermind, I was reading the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The target
aarch64-unknown-none-softfloatstill sets theneontarget feature, so the assembly implementations are incorrectly being enabled. Update gates to differentiate thesoftfloatABI.