Skip to content

Remove unused crate_owner_invitations.token_generated_at column #10548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Feb 11, 2025

This column has never been used in the 5 years that it existed. The corresponding CrateOwnerInvitation model struct even called it token_created_at instead of token_generated_at, so it couldn't have been used even if the field was accessed...

Also, the value is exactly equivalent to the created_at column since we never update the token column.

Verified

This commit was signed with the committer’s verified signature.
Turbo87 Tobias Bieniek
This column has never been used in the 5 years that it existed. The corresponding `CrateOwnerInvitation` model struct even called it `token_created_at` instead of `token_generated_at`, so it couldn't have been used even if the field was accessed...
@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Feb 11, 2025
@Turbo87 Turbo87 merged commit 75eb08a into rust-lang:main Feb 11, 2025
10 checks passed
@Turbo87 Turbo87 deleted the unused-column branch February 11, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant