Remove CaptureUserIdFromCookie middleware in favor accessing cookie directly
#3280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
the
C-internal 🔧
Turbo87
force-pushed
the
session-middleware
branch
from
c6d773d to
c851ffb
Compare
... instead of adding the `TrustedUserId` extension directly
Turbo87
force-pushed
the
session-middleware
branch
from
c851ffb to
f36e757
Compare
|
@bors r+ |
|
📌 Commit f36e757 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #2651
Unfortunately for this to work we have to use a few implementation details of
conduit_cookie, but since we control the crate ourselves I guess this is a reasonable tradeoff. Ideally theconduit_cookiecrate would export some kind of test helper function though.r? @jtgeibel
/cc @jsha