adding SUN_LEN macro to linux glibc/musl #4269
Conversation
devnexen
force-pushed
the
linux_sun_len
branch
from
b247c2b to
ee55445
Compare
|
I'm just going to mark this blocked since I don't yet know what to do without @rustbot blocked |
|
Reminder, once the PR becomes ready for a review, use |
devnexen
force-pushed
the
linux_sun_len
branch
from
ee55445 to
7236f08
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
devnexen
force-pushed
the
linux_sun_len
branch
5 times, most recently
from
8b3eb59 to
8891822
Compare
devnexen
force-pushed
the
linux_sun_len
branch
from
8891822 to
83539f3
Compare
|
@rustbot ready |
| #[cfg(target_env = "gnu")] | ||
| #[allow(unused_unsafe)] | ||
| pub fn SUN_LEN(s: crate::sockaddr_un) -> usize { | ||
| offset_of!(crate::sockaddr_un, sun_path) + crate::strlen(s.sun_path.as_ptr()) | ||
| } |
There was a problem hiding this comment.
Could you add #[allow(unused_unsafe)] in the macro instead? There isn't any unsafe here.
| let fptr = unsafe { core::ptr::addr_of!((*ptr).$field) }; | ||
| let off = (fptr as usize).checked_sub(ptr as usize).unwrap(); | ||
| assert!(off <= core::mem::size_of::<$Ty>()); | ||
| core::assert!(off <= core::mem::size_of::<$Ty>()); |
There was a problem hiding this comment.
If you could split macro changes to a separate commit that would be ideal (distinct changes in separate commits makes the backporting easier)
- assert! access from core. - nested unsafe raises an error on older rust compilers on CI.
3 participants
glibc ref musl ref