libc: remove uses of enum as per #4419 #4575
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbyx
force-pushed
the
libc-remove-enum
branch
4 times, most recently
from
99cd358 to
2f1e1da
Compare
tgross35
reviewed
Jul 26, 2025
src/macros.rs
Outdated
| ( | ||
| ($( | ||
| $(#[repr($repr:ty)])? | ||
| enum $ty_name:ident { |
There was a problem hiding this comment.
Could this require the pub keyword since we make the types pub? Similar to the other macros
src/unix/linux_like/linux/mod.rs
Outdated
| @@ -798,7 +798,6 @@ s! { | |||
| } | |||
|
|
|||
| // linux/openat2.h | |||
| #[non_exhaustive] | |||
There was a problem hiding this comment.
Why are these changes here?
tgross35
added
the
stable-declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes all uses of
enums, replacing them withc_enums. Since c_enums creates numeric types and constants,cfg_attrs were also removed for derivingCopyandClone. As per #4419Additionally allow
c_enumto take more than oneenumas input, similar to the other macros.Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI