libc: make structs non_exhaustive by default. #4579
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbyx
force-pushed
the
libc-non-exhaustive
branch
from
5af4be6 to
d10b5ad
Compare
tgross35
reviewed
Jul 26, 2025
| /// Use [`s_no_extra_traits`] for structs where the `extra_traits` feature does not | ||
| /// make sense, and for unions. | ||
| macro_rules! s { | ||
| ($( | ||
| $(#[@$not_non_exhaustive:ident])* |
There was a problem hiding this comment.
This should just be able to match a literal, right?
Suggested change
| $(#[@$not_non_exhaustive:ident])* | |
| $(#[not_non_exhaustive])? |
There was a problem hiding this comment.
Nope, it fails with "attempted to repeat an expression containing no syntax variables"
mbyx
force-pushed
the
libc-non-exhaustive
branch
from
d10b5ad to
12de1ba
Compare
|
The errors are strange, is it because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By default all structs that use the
sands_no_extra_traitsmacros are nownon_exhaustive. Structs can opt out of this if their first attribute is#[@not_non_exhaustive].The
@was necessary so that Rust could differentiate between a normal attribute (which cannot have an@) and this. Another possible syntax that we could use instead is#[@not(non_exhaustive)].Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI