Update to edition 2024 #4311
Merged
Update to edition 2024 #4311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
est31
force-pushed
the
edition_2024
branch
2 times, most recently
from
a0f0a8b to
47295e8
Compare
RalfJung
reviewed
May 7, 2025
There was a problem hiding this comment.
This might be easier if you only update Miri itself, not all the test / benchmark crates.
RalfJung
reviewed
May 7, 2025
RalfJung
reviewed
May 8, 2025
test-cargo-miri/cdylib/src/lib.rs
Outdated
| #[no_mangle] | ||
| extern "C" fn use_the_dependency() { | ||
| #[unsafe(no_mangle)] | ||
| unsafe extern "C" fn use_the_dependency() { |
There was a problem hiding this comment.
Why did you make this function unsafe?
There was a problem hiding this comment.
Fair point, it's not required indeed.
|
@rustbot author |
rustbot
added
the
S-waiting-on-author
|
Reminder, once the PR becomes ready for a review, use |
|
This looks great, thanks! Please squash the commits using @rustbot author |
Also update the format edition to 2024
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates everything but the tests to edition 2024, of which a bunch are failing on older editions.
The edition 2024 is a prerequisite for removal of the
#![feature(let_chains)], and to forbidding let chains on edition 2021. I will do this in a later PR.rust-lang/rust#140722