Skip to content

Remove note on accepted invalid should_panic syntax #1955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2025
Merged

Remove note on accepted invalid should_panic syntax #1955

merged 1 commit into from
Aug 8, 2025

Conversation

traviscross
Copy link
Contributor

We had left a note about the fact that we accepted syntax for the should_panic attribute that was invalid. We no longer do, so let's remove that note.

See:

cc @ehuss @Zalathar

@traviscross
Remove note on accepted invalid should_panic syntax
0f2dc1a 
We had left a note about the fact that we accepted syntax for the
`should_panic` attribute that was invalid.  We no longer do, so let's
remove that note.
@rustbot rustbot added the S-waiting-on-review Status: The marked PR is awaiting review from a maintainer label Aug 7, 2025
@traviscross traviscross mentioned this pull request Aug 7, 2025
Merged
@traviscross traviscross added the S-waiting-on-stabilization Waiting for a stabilization PR to be merged in the main Rust repository label Aug 7, 2025
ehuss
ehuss approved these changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ehuss ehuss added this pull request to the merge queue Aug 8, 2025
Merged via the queue into master with commit 9b6bf76 Aug 8, 2025
5 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: The marked PR is awaiting review from a maintainer label Aug 8, 2025
@rustbot rustbot mentioned this pull request Aug 11, 2025
Merged
fmease added a commit to fmease/rust that referenced this pull request Aug 11, 2025
@fmease
Rollup merge of rust-lang#145263 - rustbot:docs-update, r=ehuss
590eae8 
Update books

## rust-lang/reference

6 commits in 1be151c051a082b542548c62cafbcb055fa8944f..59b8af811886313577615c2cf0e045f01faed88b
2025-08-10 18:21:53 UTC to 2025-08-08 01:00:04 UTC

- Add LoongArch32 to inline-assembly documentation (rust-lang/reference#1942)
- Update `no_builtins` to use the attribute template (rust-lang/reference#1909)
- Update `global_allocator` to use the attribute template (rust-lang/reference#1919)
- Update `windows_subsystem` to use the attribute template (rust-lang/reference#1920)
- Remove note on accepted invalid `should_panic` syntax (rust-lang/reference#1955)
- specify relative drop order of pattern bindings (rust-lang/reference#1953)

## rust-lang/rust-by-example

1 commits in bd1279cdc9865bfff605e741fb76a0b2f07314a7..adc1f3b9012ad3255eea2054ca30596a953d053d
2025-08-08 12:02:24 UTC to 2025-08-08 12:02:24 UTC

- Update Chinese translations in `zh.po` (rust-lang/rust-by-example#1950)
fmease added a commit to fmease/rust that referenced this pull request Aug 12, 2025
@fmease
Rollup merge of rust-lang#145263 - rustbot:docs-update, r=ehuss
315b7fc 
Update books

## rust-lang/reference

6 commits in 1be151c051a082b542548c62cafbcb055fa8944f..59b8af811886313577615c2cf0e045f01faed88b
2025-08-10 18:21:53 UTC to 2025-08-08 01:00:04 UTC

- Add LoongArch32 to inline-assembly documentation (rust-lang/reference#1942)
- Update `no_builtins` to use the attribute template (rust-lang/reference#1909)
- Update `global_allocator` to use the attribute template (rust-lang/reference#1919)
- Update `windows_subsystem` to use the attribute template (rust-lang/reference#1920)
- Remove note on accepted invalid `should_panic` syntax (rust-lang/reference#1955)
- specify relative drop order of pattern bindings (rust-lang/reference#1953)

## rust-lang/rust-by-example

1 commits in bd1279cdc9865bfff605e741fb76a0b2f07314a7..adc1f3b9012ad3255eea2054ca30596a953d053d
2025-08-08 12:02:24 UTC to 2025-08-08 12:02:24 UTC

- Update Chinese translations in `zh.po` (rust-lang/rust-by-example#1950)
fmease added a commit to fmease/rust that referenced this pull request Aug 12, 2025
@fmease
Rollup merge of rust-lang#145263 - rustbot:docs-update, r=ehuss
c7bf778 
Update books

## rust-lang/reference

6 commits in 1be151c051a082b542548c62cafbcb055fa8944f..59b8af811886313577615c2cf0e045f01faed88b
2025-08-10 18:21:53 UTC to 2025-08-08 01:00:04 UTC

- Add LoongArch32 to inline-assembly documentation (rust-lang/reference#1942)
- Update `no_builtins` to use the attribute template (rust-lang/reference#1909)
- Update `global_allocator` to use the attribute template (rust-lang/reference#1919)
- Update `windows_subsystem` to use the attribute template (rust-lang/reference#1920)
- Remove note on accepted invalid `should_panic` syntax (rust-lang/reference#1955)
- specify relative drop order of pattern bindings (rust-lang/reference#1953)

## rust-lang/rust-by-example

1 commits in bd1279cdc9865bfff605e741fb76a0b2f07314a7..adc1f3b9012ad3255eea2054ca30596a953d053d
2025-08-08 12:02:24 UTC to 2025-08-08 12:02:24 UTC

- Update Chinese translations in `zh.po` (rust-lang/rust-by-example#1950)
fmease added a commit to fmease/rust that referenced this pull request Aug 12, 2025
@fmease
Rollup merge of rust-lang#145263 - rustbot:docs-update, r=ehuss
0662cf5 
Update books

## rust-lang/reference

6 commits in 1be151c051a082b542548c62cafbcb055fa8944f..59b8af811886313577615c2cf0e045f01faed88b
2025-08-10 18:21:53 UTC to 2025-08-08 01:00:04 UTC

- Add LoongArch32 to inline-assembly documentation (rust-lang/reference#1942)
- Update `no_builtins` to use the attribute template (rust-lang/reference#1909)
- Update `global_allocator` to use the attribute template (rust-lang/reference#1919)
- Update `windows_subsystem` to use the attribute template (rust-lang/reference#1920)
- Remove note on accepted invalid `should_panic` syntax (rust-lang/reference#1955)
- specify relative drop order of pattern bindings (rust-lang/reference#1953)

## rust-lang/rust-by-example

1 commits in bd1279cdc9865bfff605e741fb76a0b2f07314a7..adc1f3b9012ad3255eea2054ca30596a953d053d
2025-08-08 12:02:24 UTC to 2025-08-08 12:02:24 UTC

- Update Chinese translations in `zh.po` (rust-lang/rust-by-example#1950)
fmease added a commit to fmease/rust that referenced this pull request Aug 12, 2025
@fmease
Rollup merge of rust-lang#145263 - rustbot:docs-update, r=ehuss
30bff95 
Update books

## rust-lang/reference

6 commits in 1be151c051a082b542548c62cafbcb055fa8944f..59b8af811886313577615c2cf0e045f01faed88b
2025-08-10 18:21:53 UTC to 2025-08-08 01:00:04 UTC

- Add LoongArch32 to inline-assembly documentation (rust-lang/reference#1942)
- Update `no_builtins` to use the attribute template (rust-lang/reference#1909)
- Update `global_allocator` to use the attribute template (rust-lang/reference#1919)
- Update `windows_subsystem` to use the attribute template (rust-lang/reference#1920)
- Remove note on accepted invalid `should_panic` syntax (rust-lang/reference#1955)
- specify relative drop order of pattern bindings (rust-lang/reference#1953)

## rust-lang/rust-by-example

1 commits in bd1279cdc9865bfff605e741fb76a0b2f07314a7..adc1f3b9012ad3255eea2054ca30596a953d053d
2025-08-08 12:02:24 UTC to 2025-08-08 12:02:24 UTC

- Update Chinese translations in `zh.po` (rust-lang/rust-by-example#1950)
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 12, 2025
@Zalathar
Rollup merge of rust-lang#145263 - rustbot:docs-update, r=ehuss
9d16f12 
Update books

## rust-lang/reference

6 commits in 1be151c051a082b542548c62cafbcb055fa8944f..59b8af811886313577615c2cf0e045f01faed88b
2025-08-10 18:21:53 UTC to 2025-08-08 01:00:04 UTC

- Add LoongArch32 to inline-assembly documentation (rust-lang/reference#1942)
- Update `no_builtins` to use the attribute template (rust-lang/reference#1909)
- Update `global_allocator` to use the attribute template (rust-lang/reference#1919)
- Update `windows_subsystem` to use the attribute template (rust-lang/reference#1920)
- Remove note on accepted invalid `should_panic` syntax (rust-lang/reference#1955)
- specify relative drop order of pattern bindings (rust-lang/reference#1953)

## rust-lang/rust-by-example

1 commits in bd1279cdc9865bfff605e741fb76a0b2f07314a7..adc1f3b9012ad3255eea2054ca30596a953d053d
2025-08-08 12:02:24 UTC to 2025-08-08 12:02:24 UTC

- Update Chinese translations in `zh.po` (rust-lang/rust-by-example#1950)
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 12, 2025
@Zalathar
Rollup merge of rust-lang#145263 - rustbot:docs-update, r=ehuss
0264abc 
Update books

## rust-lang/reference

6 commits in 1be151c051a082b542548c62cafbcb055fa8944f..59b8af811886313577615c2cf0e045f01faed88b
2025-08-10 18:21:53 UTC to 2025-08-08 01:00:04 UTC

- Add LoongArch32 to inline-assembly documentation (rust-lang/reference#1942)
- Update `no_builtins` to use the attribute template (rust-lang/reference#1909)
- Update `global_allocator` to use the attribute template (rust-lang/reference#1919)
- Update `windows_subsystem` to use the attribute template (rust-lang/reference#1920)
- Remove note on accepted invalid `should_panic` syntax (rust-lang/reference#1955)
- specify relative drop order of pattern bindings (rust-lang/reference#1953)

## rust-lang/rust-by-example

1 commits in bd1279cdc9865bfff605e741fb76a0b2f07314a7..adc1f3b9012ad3255eea2054ca30596a953d053d
2025-08-08 12:02:24 UTC to 2025-08-08 12:02:24 UTC

- Update Chinese translations in `zh.po` (rust-lang/rust-by-example#1950)
rust-timer added a commit to rust-lang/rust that referenced this pull request Aug 12, 2025
@rust-timer
Unrolled build for #145263
fae6ef2 
Rollup merge of #145263 - rustbot:docs-update, r=ehuss

Update books

## rust-lang/reference

6 commits in 1be151c051a082b542548c62cafbcb055fa8944f..59b8af811886313577615c2cf0e045f01faed88b
2025-08-10 18:21:53 UTC to 2025-08-08 01:00:04 UTC

- Add LoongArch32 to inline-assembly documentation (rust-lang/reference#1942)
- Update `no_builtins` to use the attribute template (rust-lang/reference#1909)
- Update `global_allocator` to use the attribute template (rust-lang/reference#1919)
- Update `windows_subsystem` to use the attribute template (rust-lang/reference#1920)
- Remove note on accepted invalid `should_panic` syntax (rust-lang/reference#1955)
- specify relative drop order of pattern bindings (rust-lang/reference#1953)

## rust-lang/rust-by-example

1 commits in bd1279cdc9865bfff605e741fb76a0b2f07314a7..adc1f3b9012ad3255eea2054ca30596a953d053d
2025-08-08 12:02:24 UTC to 2025-08-08 12:02:24 UTC

- Update Chinese translations in `zh.po` (rust-lang/rust-by-example#1950)
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Aug 13, 2025
@Zalathar
Rollup merge of #145263 - rustbot:docs-update, r=ehuss
7bc726f 
Update books

## rust-lang/reference

6 commits in 1be151c051a082b542548c62cafbcb055fa8944f..59b8af811886313577615c2cf0e045f01faed88b
2025-08-10 18:21:53 UTC to 2025-08-08 01:00:04 UTC

- Add LoongArch32 to inline-assembly documentation (rust-lang/reference#1942)
- Update `no_builtins` to use the attribute template (rust-lang/reference#1909)
- Update `global_allocator` to use the attribute template (rust-lang/reference#1919)
- Update `windows_subsystem` to use the attribute template (rust-lang/reference#1920)
- Remove note on accepted invalid `should_panic` syntax (rust-lang/reference#1955)
- specify relative drop order of pattern bindings (rust-lang/reference#1953)

## rust-lang/rust-by-example

1 commits in bd1279cdc9865bfff605e741fb76a0b2f07314a7..adc1f3b9012ad3255eea2054ca30596a953d053d
2025-08-08 12:02:24 UTC to 2025-08-08 12:02:24 UTC

- Update Chinese translations in `zh.po` (rust-lang/rust-by-example#1950)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss approved these changes

Assignees
No one assigned
Labels
S-waiting-on-stabilization Waiting for a stabilization PR to be merged in the main Rust repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@traviscross @ehuss @rustbot