Merged
Conversation
BurntSushi
requested changes
Feb 14, 2024
Member
BurntSushi
left a comment
There was a problem hiding this comment.
Yeah, "or" was definitely intended. Thank you. :-)
Could you apply the same fix to regex-lite/src/lib.rs? It looks like it has precisely the same mistake. (Many of its docs are copy & pasted from regex proper.)
Member
|
I applied the requested doc fix to |
Contributor
Author
|
Oop, sorry, completely missed the follow up request. Glad this got merged eventually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In multi-line CRLF mode (
?Rm), the start-of-line and end-of-line assertions match either\ror\n; the current documentation says "and" instead. The use of "and" implies that the full two-byte\r\nsequence is required, but that's not the case; a lone\nstill satisfies the assertions, as does a lone\r. "or" makes this clear, and was likely intended; "either $x and $y" doesn't make grammatical sense. You could argue for using "and/or" to emphasize that the assertions do match\r\nnewlines, but I think doing so is probably unnecessary and what the "and" could be trying to communicate is much better said by the immediately following clause anyway.Tested: