Fix not applicable on ambiguous ident pat for merge_match_arms#21411
Open
A4-Tacks wants to merge 1 commit intorust-lang:masterfrom
Open
Fix not applicable on ambiguous ident pat for merge_match_arms#21411A4-Tacks wants to merge 1 commit intorust-lang:masterfrom
A4-Tacks wants to merge 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
Example
---
```rust
enum X {
A,
B,
C,
}
use X::*;
fn main() {
match A {
$0A => todo!(),
B => todo!(),
C => todo!(),
}
}
```
**Before this PR**
Assist not applicable
**After this PR**
```rust
enum X {
A,
B,
C,
}
use X::*;
fn main() {
match A {
A | B => todo!(),
C => todo!(),
}
}
```
A4-Tacks
force-pushed
the
merge-ambig-ident-pat
branch
from
7fff6d9 to
8072f1a
Compare
A4-Tacks
changed the title
| } | ||
| } | ||
| ast::Pat::IdentPat(ident_pat) => { | ||
| let has_type = ctx.sema.type_of_pat(local_pat).is_some(); |
Contributor
There was a problem hiding this comment.
Is there a pattern without a type? This is weird. Every pattern has a type, even binding patterns. Are you sure this code is treating the other way around, that is binding patterns, correctly?
Member
Author
There was a problem hiding this comment.
Are you sure this code is treating the other way around, that is binding patterns, correctly?
There are behavioral differences in patterns and bindings:
| pattern | type_of_pat |
type_of_binding_in_pat |
|---|---|---|
| None | Some(Ty) | None |
| x | Some(Ty) | Some(Ty) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example
Before this PR
Assist not applicable
After this PR