Skip to content

Don't warn about unloaded crates #14733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2025

Conversation

smoelius
Copy link
Contributor

@smoelius smoelius commented May 4, 2025

Fixes #14397 (comment)

r? @samueltardieu

changelog: Don't warn about clippy.toml disallowed paths for crates that were not loaded

@rustbot
Copy link
Collaborator

rustbot commented May 4, 2025

samueltardieu is on vacation.

Please choose another assignee.

@rustbot
Copy link
Collaborator

rustbot commented May 4, 2025

r? @Manishearth

rustbot has assigned @Manishearth.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 4, 2025
Copy link
Member

@Alexendoo Alexendoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Alexendoo Alexendoo added this pull request to the merge queue May 4, 2025
Merged via the queue into rust-lang:master with commit ea13461 May 4, 2025
11 checks passed
@smoelius
Copy link
Contributor Author

smoelius commented May 4, 2025

Thanks, @Alexendoo!

@smoelius smoelius deleted the unloaded-crates branch May 5, 2025 10:43
@Alexendoo Alexendoo added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 5, 2025
@flip1995
Copy link
Member

flip1995 commented May 8, 2025

The issue that this fixes only started to appear in the current nightly 1.88. This would need an out-of-cycle sync, so that it doesn't land in beta. I'll leave it as nominated to backport it to the next beta, after this is synced to the Rust master. (I might do a beta backport right after the 1.87 release).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-nominated Nominated for backporting to the compiler in the beta channel. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants