Rework missing_docs_in_private_items
#14741
Open
+3,235
−834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
* Don't search spans between items for comments. * Don't lint items inside bodies, automatically derived impls. * Don't lint items inside macro generated modules unless they are namable outside. * Delay `is_from_proc_macro` checks * Handle reexports when checking if an item is reachable from the crate root. * Don't lint the crate root.
|
Looks like vscode did something weird and disappeared the new test file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is blocking #14724 as it triggers the debug assertions it adds.
The inter item span parsing was introduced to solve #12197. This is better handled by just not linting anything within bodies.
changelog: [
missing_docs_in_private_items]: Don't lint items in bodies and automatically derived implschangelog: [
missing_docs_in_private_items]: Better detect when things are accessible from the crate rootchangelog: [
missing_docs_in_private_items]: Lint unnameable items which are accessible outside the crate