Skip to content

Remove automatic feature freeze comment #15690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2025
Merged

Remove automatic feature freeze comment #15690

merged 1 commit into from
Sep 18, 2025

Conversation

samueltardieu
Copy link
Member

The feature freeze period is over.

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 17, 2025

flip1995 is not on the review rotation at the moment.
They may take a while to respond.

@rustbot
Copy link
Collaborator

rustbot commented Sep 17, 2025

r? @flip1995

rustbot has assigned @flip1995.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

blyxyas
blyxyas requested changes Sep 17, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also remove or deprecate the sections in the book & remove the warnings in other files

View changes since this review

@flip1995
Copy link
Member

r? blyxyas

I had the same comment. As Alejandra has to unblock this PR anyway, I'll reassign to her.

@rustbot rustbot assigned blyxyas and unassigned flip1995 Sep 17, 2025
@samueltardieu
Remove automatic feature freeze comment
301092e 
The feature freeze period is over.
@samueltardieu
Copy link
Member Author

I can't find the "feature freeze" pattern in the repository anymore.

@samueltardieu
Copy link
Member Author

@blyxyas Could you merge this? I've removed the mention of the feature freeze in the book. It would be best if people didn't get the message about the feature freeze on new PRs since it is now officially over.

I had the same comment. As Alejandra has to unblock this PR anyway, I'll reassign to her.

@flip1995 Really? I thought only the assigned reviewer(s)'s request for changes would block merging a request, but I might be wrong.

@blyxyas blyxyas added this pull request to the merge queue Sep 18, 2025
Merged via the queue into rust-lang:master with commit a3c7f63 Sep 18, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 18, 2025
@flip1995
Copy link
Member

Really? I thought only the assigned reviewer(s)'s request for changes would block merging a request, but I might be wrong.

I don't think this is possible to configure. Either changes-requested-review by any maintainer blocks the PR or none do. I hope that we have it set up to block merging if any maintainer requests changes.

@lukaslueg lukaslueg mentioned this pull request Sep 18, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 18, 2025
@samueltardieu
Remove feature-freeze from gh templates (#15698)
8428b16 
ping #15690

changelog: none
@samueltardieu samueltardieu deleted the end-of-feature-freeze branch September 18, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blyxyas blyxyas blyxyas approved these changes

Assignees

@blyxyas blyxyas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samueltardieu @rustbot @flip1995 @blyxyas