Remove rust-tools-util - #17574
Conversation
* Move all argument parsing into a single loop. * Print an error when `--explain` is missing an argument. * Print an error when there are multiple `--explain` arguments. * Don't parse flags after `--`
* Only produce a single version string in the build script
|
Thanks for the pull request. A reviewer will take a look after it receives 2 community reviews. In the meantime, we would highly appreciate if you could try to review any of PRs waiting on community reviews. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-community-reviews
| @@ -1,153 +1,166 @@ | |||
| // We need this feature as it changes `dylib` linking behavior and allows us to link to | |||
| // `rustc_driver`. | |||
| #![feature(rustc_private)] | |||
There was a problem hiding this comment.
you sure you want to remove the explainer?
|
FWIW, miri is still using this. But a version from crates.io, so us removing this now should be fine. |
|
☔ The latest upstream changes (possibly #17632) made this pull request unmergeable. Please resolve the merge conflicts. |
4 participants
Based on #17573, but it doesn't really need it. Only the second commit is relevant to this PR.
This removes the
rustc_tools_utilcrate and inlines only the part we actually use.cc @flip1995
changelog: none