Syntax: Rewrite macro_rules #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
Merge conflict (retrying...) |
7 similar comments
Merge conflict (retrying...) |
Merge conflict (retrying...) |
Merge conflict (retrying...) |
Merge conflict (retrying...) |
Merge conflict (retrying...) |
Merge conflict (retrying...) |
Merge conflict (retrying...) |
Merge conflict |
macro_rules failed in a lot of cases, this reworks it to fully support: - Complete matcher syntax. - Better bracket balancing support. - Add `lifetime` designator (1.28). - More resilient to odd syntax within the transcriber. The content doesn't have to be Rust syntax, so it can sometimes get confused. Add a few escapes so it at least doesn't barf. - At-most-once kleene operator (2018).
ehuss
force-pushed
the
syntax-macro-rules
branch
from
32dd27c to
b9a965f
Compare
|
bors r+ |
Merge conflict (retrying...) |
bors bot
added a commit
that referenced
this pull request
Aug 20, 2018
326: Syntax: Rewrite macro_rules r=ehuss a=ehuss macro_rules failed in a lot of cases, this reworks it to fully support: - Complete matcher syntax. - Better bracket balancing support. - Add `lifetime` designator (1.28). - More resilient to odd syntax within the transcriber. The content doesn't have to be Rust syntax, so it can sometimes get confused. Add a few escapes so it at least doesn't barf. - At-most-once kleene operator (2018). Closes #311 <img width="903" alt="image" src="https://user-images.githubusercontent.com/43198/43736311-018cc660-9972-11e8-8931-d4d2bd5e7501.png"> Co-authored-by: Eric Huss <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macro_rules failed in a lot of cases, this reworks it to fully support:
lifetimedesignator (1.28).to be Rust syntax, so it can sometimes get confused. Add a few escapes so it
at least doesn't barf.
Closes #311