Rollup of 7 pull requests #101577

Dylan-DPC · 2022-09-08T15:18:40Z

Successful merges:

Opaque types' generic params do not imply anything about their hidden type's lifetimes #98933 (Opaque types' generic params do not imply anything about their hidden type's lifetimes)
translations(rustc_session): migrates rustc_session to use SessionDiagnostic - Pt. 2 #101041 (translations(rustc_session): migrates rustc_session to use SessionDiagnostic - Pt. 2)
Adjust and slightly generalize operator error suggestion #101424 (Adjust and slightly generalize operator error suggestion)
Allow lower_lifetime_binder receive a closure #101496 (Allow lower_lifetime_binder receive a closure)
Allow lint passes to be bound by TyCtxt #101501 (Allow lint passes to be bound by TyCtxt)
Recover from typo where == is used in place of = #101515 (Recover from typo where == is used in place of =)
Remove unnecessary PartialOrd and Ord #101545 (Remove unnecessary PartialOrd and Ord)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

…rked with rustc_lint_diagnostic This commit removes the allows rules for the SessionDiagnostic lint that were being used in the session.rs file. Thanks to the PR rust-lang#101230 we do not need to annotate the methods with the allow rule as they are part of the diagnostic machinery.

… type's lifetimes

…times, r=lcnr Opaque types' generic params do not imply anything about their hidden type's lifetimes fixes rust-lang#97104 cc ```@aliemjay```

…name-attr-warning-pt2, r=davidtwco translations(rustc_session): migrates rustc_session to use SessionDiagnostic - Pt. 2 # Description This is the second part of the `rustc_session` [migration](rust-lang#100717 (comment)). **Please only review this [commit](rust-lang@5018581) that belongs to the part 2. The other ones are from the PR [rust-lang#100753](rust-lang#100753) that is not yet merged.** In this PR, we migrate the files `session.rs` and `config.rs`. Please not that we have to `allow` the lints rules in some functions from `session.rs` because they are (at least I believe) part of the diagnostic machinery.

… r=TaKO8Ki Adjust and slightly generalize operator error suggestion (in no particular order) * Stop passing around a whole extra `ProjectionPredicate` * Add spaces around `=` in `Trait<..., Output = Ty>` suggestion * Some code clean-ups, including * add `lang_item_for_op` to turn a `Op` into a `DefId` * avoid `SourceMap` because we don't really need to render an expr * Remove `TypeParamVisitor` in favor of just checking `ty.has_param_types_or_consts` -- this acts a bit differently, but shouldn't cause erroneous suggestions (actually might generalize them a bit) * We now suggest `Output = Ty` in the `where` clause suggestion when we fail to add `Struct<T>` and `T`. I can split this out into more PRs if needed, but they're all just miscellaneous generalizations, changes, and nitpicks I saw when messing with this operator code.

…pi_changes, r=oli-obk Allow lower_lifetime_binder receive a closure ``@oli-obk`` requested this and other changes as a way of simplifying rust-lang#101345. This is just going to make the diff of rust-lang#101345 smaller. r? ``@oli-obk`` ``@cjgillot``

Allow lint passes to be bound by `TyCtxt` This will allow storing things like `Ty<'tcx>` inside late lint passes. It's already possible to store various id types so they're already implicitly bound to a specific `TyCtxt`. r? rust-lang/compiler

Recover from typo where == is used in place of = Fixes rust-lang#101477

…ord-ord, r=oli-obk Remove unnecessary `PartialOrd` and `Ord`

Dylan-DPC · 2022-09-08T15:19:01Z

@bors r+ rollup=never p=5

bors · 2022-09-08T15:19:10Z

📌 Commit 720a82d has been approved by Dylan-DPC

It is now in the queue for this repository.

bors · 2022-09-08T15:53:18Z

⌛ Testing commit 720a82d with merge 8778809...

bors · 2022-09-08T18:24:24Z

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing 8778809 to master...

rust-timer · 2022-09-08T18:26:41Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#101545	b8ed5d0615eccecb1e0b460fba67dc9ea2de9f30
#101515	45ff52f6a98d6f08736fa960ee73fffc3a3b69c3
#101501	b8526e79d1b96e17651b1ac1720fad707acb0e76
#101496	b604c03c8ccddedf8d44870394951de41a801f0e
#101424	8cda7f7b523ac8fff251aadafb953afcdf2d79dd
#101041	ccd6ddd5f2c8d8e16cd3ff71321b35311c860190
#98933	6f7528f662dc69bf3b6ea7dec4fc7726a151eaf0

previous master: 24d6992020

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2022-09-09T00:55:28Z

Finished benchmarking commit (8778809): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.1%	[-1.1%, -1.1%]	1
Improvements ✅ (secondary)	-7.5%	[-7.5%, -7.5%]	1
All ❌✅ (primary)	-1.1%	[-1.1%, -1.1%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[2.8%, 2.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-2.8%, -0.9%]	5
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-3.6%	[-3.6%, -3.6%]	1
All ❌✅ (primary)	-2.3%	[-2.3%, -2.3%]	1

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

Rollup of 7 pull requests Successful merges: - rust-lang#98933 (Opaque types' generic params do not imply anything about their hidden type's lifetimes) - rust-lang#101041 (translations(rustc_session): migrates rustc_session to use SessionDiagnostic - Pt. 2) - rust-lang#101424 (Adjust and slightly generalize operator error suggestion) - rust-lang#101496 (Allow lower_lifetime_binder receive a closure) - rust-lang#101501 (Allow lint passes to be bound by `TyCtxt`) - rust-lang#101515 (Recover from typo where == is used in place of =) - rust-lang#101545 (Remove unnecessary `PartialOrd` and `Ord`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

Jarcho and others added 23 commits September 6, 2022 14:23

Allow lint passes to be bound by TyCtxt

0126f7f

Allow lower_lifetime_binder receive a closure

36fa12f

remove unnecessary PartialOrd and Ord

bdc865d

Avoid source-map call in operator error

00c9d3d

Simplify printing operator lang item paths in error message

d0746e8

Remove TypeParamVisitor

0dbbf0f

Add associated item binding to non-param-ty where clause suggestions

30e3673

Adjust spacing in suggestion, add a test

48281b0

translations(rustc_session): migrates session.rs and config.rs

60b4958

translations(rustc_session): migrate TargetDataLayout::parse

0f06320

fixes rust-lang#101477: Recover from typo where == is used in place of =

ddb225f

Opaque types' generic params do not imply anything about their hidden…

5c9d28d

… type's lifetimes

Uncomment unsound code example

5cd3cc1

Clarify some diagnostic messages

64d11fc

translations(rustc_session): migrates two diagnostics in session.rs

0e497a7

Rollup merge of rust-lang#98933 - oli-obk:opaque_type_late_bound_life…

d392838

…times, r=lcnr Opaque types' generic params do not imply anything about their hidden type's lifetimes fixes rust-lang#97104 cc ```@aliemjay```

Rollup merge of rust-lang#101515 - chenyukang:fix-101477, r=fee1-dead

8d2a492

Recover from typo where == is used in place of = Fixes rust-lang#101477

Rollup merge of rust-lang#101545 - TaKO8Ki:remove-unnecessary-partial…

720a82d

…ord-ord, r=oli-obk Remove unnecessary `PartialOrd` and `Ord`

rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Sep 8, 2022

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 8, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 8, 2022

bors merged commit 8778809 into rust-lang:master Sep 8, 2022

rustbot added this to the 1.65.0 milestone Sep 8, 2022

davidtwco removed the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Oct 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 7 pull requests #101577

Rollup of 7 pull requests #101577

Uh oh!

Dylan-DPC commented Sep 8, 2022

Uh oh!

Dylan-DPC commented Sep 8, 2022

Uh oh!

bors commented Sep 8, 2022

Uh oh!

bors commented Sep 8, 2022

Uh oh!

bors commented Sep 8, 2022

Uh oh!

rust-timer commented Sep 8, 2022

Uh oh!

rust-timer commented Sep 9, 2022

Uh oh!

Uh oh!

Rollup of 7 pull requests #101577

Rollup of 7 pull requests #101577

Uh oh!

Conversation

Dylan-DPC commented Sep 8, 2022

Uh oh!

Dylan-DPC commented Sep 8, 2022

Uh oh!

bors commented Sep 8, 2022

Uh oh!

bors commented Sep 8, 2022

Uh oh!

bors commented Sep 8, 2022

Uh oh!

rust-timer commented Sep 8, 2022

Uh oh!

rust-timer commented Sep 9, 2022

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

Uh oh!