Skip to content

Conversation

reitermarkus
Copy link
Contributor

@reitermarkus reitermarkus commented Feb 22, 2024

Tracking issue: #120257

Use generic NonZero everywhere (except stable examples).

r? @dtolnay

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 22, 2024
@rust-log-analyzer

This comment has been minimized.

@reitermarkus reitermarkus force-pushed the generic-nonzero-library branch from 36bb4d9 to b74d8db Compare February 22, 2024 16:16
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dtolnay
Copy link
Member

dtolnay commented Feb 23, 2024

@bors r+
@bors delegate+

Delegating in case a merge conflict requires rebasing, as I already see in #121461 (comment)—feel free to use r=dtolnay after rebase.

@bors
Copy link
Collaborator

bors commented Feb 23, 2024

📌 Commit b74d8db has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2024
@bors
Copy link
Collaborator

bors commented Feb 23, 2024

✌️ @reitermarkus, you can now approve this pull request!

If @dtolnay told you to "r=me" after making some further change, please make that change, then do @bors r=@dtolnay

@matthiaskrgr
Copy link
Member

@bors rollup=iffy

@bors
Copy link
Collaborator

bors commented Feb 23, 2024

⌛ Testing commit b74d8db with merge b6a23b8...

@bors
Copy link
Collaborator

bors commented Feb 23, 2024

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing b6a23b8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 23, 2024
@bors bors merged commit b6a23b8 into rust-lang:master Feb 23, 2024
@rustbot rustbot added this to the 1.78.0 milestone Feb 23, 2024
@reitermarkus reitermarkus deleted the generic-nonzero-library branch February 23, 2024 16:32
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b6a23b8): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.0% [4.0%, 4.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.6% [0.6%, 0.6%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.6% [0.6%, 0.6%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 649.924s -> 648.956s (-0.15%)
Artifact size: 311.02 MiB -> 311.02 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants