Skip to content

Conversation

saethlin
Copy link
Member

Most importantly, this pulls in rust-lang/stdarch#1567 which is part of #124050

@rustbot
Copy link
Collaborator

rustbot commented Apr 22, 2024

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Apr 22, 2024

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 22, 2024
@workingjubilee
Copy link
Member

Nice.
@bors r+

@bors
Copy link
Collaborator

bors commented Apr 22, 2024

📌 Commit 9989d00 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2024
@workingjubilee
Copy link
Member

Classically, these tend to be breaky.
@bors rollup=iffy

@bors
Copy link
Collaborator

bors commented Apr 22, 2024

⌛ Testing commit 9989d00 with merge eb70af2...

@bors
Copy link
Collaborator

bors commented Apr 22, 2024

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing eb70af2 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 22, 2024
@bors bors merged commit eb70af2 into rust-lang:master Apr 22, 2024
@rustbot rustbot added this to the 1.79.0 milestone Apr 22, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (eb70af2): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.3% [0.3%, 0.3%] 1
Improvements ✅
(primary)
-1.0% [-1.0%, -1.0%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.0% [-1.0%, -1.0%] 1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.1% [2.1%, 2.1%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.1% [2.1%, 2.1%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.331s -> 672.434s (0.16%)
Artifact size: 315.43 MiB -> 315.47 MiB (0.01%)

@saethlin saethlin deleted the stdarch branch May 3, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants