Skip to content

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented May 7, 2024

<[T]>::last_chunk should have become const stable as part of #117561. Update the const stability gate to reflect this.

`<[T]>::last_chunk` should have become const stable as part of
<rust-lang#117561>. Update the const
stability gate to reflect this.
@rustbot
Copy link
Collaborator

rustbot commented May 7, 2024

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 7, 2024
@tgross35
Copy link
Contributor Author

tgross35 commented May 7, 2024

This was included in the stabilization report at #117561 and split_last_chunk became const stable, I just didn't correctly update the const gate for last_chunk at that time.

@rustbot label +T-libs-api -T-libs
r? libs-api

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 7, 2024
@rustbot rustbot assigned BurntSushi and unassigned joboet May 7, 2024
@BurntSushi
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented May 7, 2024

📌 Commit 3488679 has been approved by BurntSushi

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2024
@bors
Copy link
Collaborator

bors commented May 7, 2024

⌛ Testing commit 3488679 with merge cc8d9b6...

@bors
Copy link
Collaborator

bors commented May 7, 2024

☀️ Test successful - checks-actions
Approved by: BurntSushi
Pushing cc8d9b6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 7, 2024
@bors bors merged commit cc8d9b6 into rust-lang:master May 7, 2024
@rustbot rustbot added this to the 1.80.0 milestone May 7, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (cc8d9b6): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.4% [1.4%, 1.4%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.2% [-1.2%, -1.2%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.0% [1.0%, 1.0%] 1
Regressions ❌
(secondary)
3.9% [3.9%, 3.9%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-6.0% [-6.7%, -5.5%] 4
All ❌✅ (primary) 1.0% [1.0%, 1.0%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 675.464s -> 676.002s (0.08%)
Artifact size: 315.71 MiB -> 315.77 MiB (0.02%)

@tgross35 tgross35 deleted the const-slice-last-chunk branch May 7, 2024 18:47
@glandium
Copy link
Contributor

glandium commented Aug 3, 2024

<[T]>::last_chunk should have become const stable as part of #117561. Update the const stability gate to reflect this.

Except now the doc says it was stabilized const in 1.77, but using it as const with a version < 1.80 fails with

error: `core::slice::<impl [T]>::last_chunk` is not yet stable as a const fn

@glandium
Copy link
Contributor

glandium commented Aug 3, 2024

Opened #128619

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants