-
Notifications
You must be signed in to change notification settings - Fork 13.3k
In redesigned rustdoc toolbar: Adjust spacings and sizing to improve behavior with over-long names #131002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @jsha |
I suppose the diff of the 2nd commit is small enough (see below) that I can already squash without creating confusion in review. .rustdoc-breadcrumbs {
grid-area: main-heading-breadcrumbs;
line-height: 1.25;
+ display: flex;
+ flex-wrap: wrap;
align-items: end;
padding-top: 5px;
} |
cf8ed46
to
6683c04
Compare
This comment has been minimized.
This comment has been minimized.
Some changes occurred in GUI tests. |
@bors r+ |
Thanks to both of you for the fix and the regression test! :) |
☀️ Test successful - checks-actions |
Finished benchmarking commit (0d6e130): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 1.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 767.898s -> 768.13s (0.03%) |
Fixes #130993.
Some additional adjustments also fix more issues I’ve noticed such as:
min-height: 60px
on the toolbarto save even more space, there’s support for a little bit of extra squeezing of the buttons
I’m really not super good with HTML or CSS stuff at all; there seem to be many magical numbers already, I’ve just used
px
values until things look right, I hope that’s okay 🤷♂️r? @GuillaumeGomez
cc @notriddle