Skip to content

do not trust download-rustc=if-unchanged on CI for now #132852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2024
Merged

do not trust download-rustc=if-unchanged on CI for now #132852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3c2121
do not trust download-rustc=if-unchanged on CI for now
RalfJung Nov 10, 2024
5c9cc0c
Re-enable `version-verbose-commit-hash` run-make test
jieyouxu Nov 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/ci/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,9 @@ else
fi

if [ "$NO_DOWNLOAD_CI_RUSTC" = "" ]; then
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set rust.download-rustc=if-unchanged"
# disabled for now, see https://github.com/rust-lang/rust/issues/131658
#RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set rust.download-rustc=if-unchanged"
true
fi
fi

Expand Down
3 changes: 0 additions & 3 deletions tests/run-make/version-verbose-commit-hash/rmake.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@
// test ensures it will not be broken again.
// See https://github.com/rust-lang/rust/issues/107094

// FIXME(#132845): temporarily disabled to get revert through
//@ ignore-test

//@ needs-git-hash

use run_make_support::{bare_rustc, bare_rustdoc, regex};
Expand Down
Loading