Sync Fuchsia target spec with clang Fuchsia driver #136892

erickt · 2025-02-12T00:04:41Z

This updates the Fuchsia target spec with the Clang Fuchsia driver, which picks up a few changes:

Adds -z start-stop-visibility=hidden and -z rel to the pre link arguments.
Adds --execute-only and --fix-cortex-a53-843419 for aarch64-unknown-fuchsia.
Enables the equivalent cpu features for x86-64-v2 for x86_64-unknown-fuchsia, which is our minimum supported x86_64 platform according to RFC-0073.

try-job: x86_64-fuchsia

rustbot · 2025-02-12T00:04:49Z

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-02-12T00:04:51Z

These commits modify compiler targets.
(See the Target Tier Policy.)

compiler/rustc_target/src/spec/targets/x86_64_unknown_fuchsia.rs

compiler/rustc_target/src/spec/targets/aarch64_unknown_fuchsia.rs

bors · 2025-02-17T06:19:25Z

☔ The latest upstream changes (presumably #136953) made this pull request unmergeable. Please resolve the merge conflicts.

compiler/rustc_target/src/spec/targets/aarch64_unknown_fuchsia.rs

compiler/rustc_target/src/spec/targets/riscv64gc_unknown_fuchsia.rs

erickt · 2025-02-20T01:32:41Z

@bors try

Sync Fuchsia target spec with clang Fuchsia driver This updates the Fuchsia target spec with the [Clang Fuchsia driver], which picks up a few changes: * Adds `-z start-stop-visibility=hidden` and `-z rel` to the pre link arguments. * Adds `--execute-only` and `--fix-cortex-a53-843419` for `aarch64-unknown-fuchsia`. * Enables the equivalent cpu features for `x86-64-v2` for `x86_64-unknown-fuchsia`, which is our minimum supported x86_64 platform according to [RFC-0073]. try-job: x86_64-fuchsia [Clang Fuchsia driver]: https://github.com/llvm/llvm-project/blob/8374d421861cd3d47e21ae7889ba0b4c498e8d85/clang/lib/Driver/ToolChains/Fuchsia.cpp [RFC-0073]: https://fuchsia.dev/fuchsia-src/contribute/governance/rfcs/0073_x86_64_platform_requirement

bors · 2025-02-20T01:33:52Z

⌛ Trying commit ee372d8 with merge dcce89f...

bors · 2025-02-20T01:44:23Z

💔 Test failed - checks-actions

This updates the Fuchsia target spec with the [Clang Fuchsia driver], which picks up a few changes: * Adds `-z start-stop-visibility=hidden` and `-z rel` to the pre link arguments. * Adds `--execute-only` and `--fix-cortex-a53-843419` for `aarch64-unknown-fuchsia`. * Enables the cpu features equivalent to x86-64-v2 for `x86_64-unknown-fuchsia`, which is our minimum supported x86_64. platform according to [RFC-0073]. * Enables the cpu features `+crc,+aes,+sha2,+neon` on aarch64. * Increases the max atomic width on 86_64 to 128. * Enables stack probes and xray on aarch64 and riscv64. [Clang Fuchsia driver]: https://github.com/llvm/llvm-project/blob/8374d421861cd3d47e21ae7889ba0b4c498e8d85/clang/lib/Driver/ToolChains/Fuchsia.cpp [RFC-0073]: https://fuchsia.dev/fuchsia-src/contribute/governance/rfcs/0073_x86_64_platform_requirement

erickt · 2025-02-20T19:53:53Z

@bors try

Sync Fuchsia target spec with clang Fuchsia driver This updates the Fuchsia target spec with the [Clang Fuchsia driver], which picks up a few changes: * Adds `-z start-stop-visibility=hidden` and `-z rel` to the pre link arguments. * Adds `--execute-only` and `--fix-cortex-a53-843419` for `aarch64-unknown-fuchsia`. * Enables the equivalent cpu features for `x86-64-v2` for `x86_64-unknown-fuchsia`, which is our minimum supported x86_64 platform according to [RFC-0073]. try-job: x86_64-fuchsia [Clang Fuchsia driver]: https://github.com/llvm/llvm-project/blob/8374d421861cd3d47e21ae7889ba0b4c498e8d85/clang/lib/Driver/ToolChains/Fuchsia.cpp [RFC-0073]: https://fuchsia.dev/fuchsia-src/contribute/governance/rfcs/0073_x86_64_platform_requirement

bors · 2025-02-20T19:55:08Z

⌛ Trying commit 746b0f6 with merge b46ed62...

bors · 2025-02-20T21:38:29Z

☀️ Try build successful - checks-actions
Build commit: b46ed62 (b46ed6219967cf6e46cf381c68fb7d323a2299cc)

jieyouxu · 2025-03-10T08:05:41Z

Hi @erickt, is this ready for review?

erickt · 2025-03-10T17:18:40Z

@jieyouxu - I'll get back to you later on today, we just got fuchsia compiling again with some of the new lints that recently got turned on, so I'm doing a dry run to make sure this patch doesn't cause any problems.

jieyouxu · 2025-03-10T22:05:52Z

No rush, just asking in case it was waiting on review but I wasn't looking at it.

erickt · 2025-03-13T18:40:09Z

@jieyouxu this tested fine on our side, so it should be ready to land. Thanks!

jieyouxu

Thanks, the changes look reasonable to me as well.

jieyouxu · 2025-03-14T02:53:34Z

@bors r+ rollup

bors · 2025-03-14T02:53:37Z

📌 Commit 746b0f6 has been approved by jieyouxu

It is now in the queue for this repository.

Rollup of 16 pull requests Successful merges: - rust-lang#136001 (Overhaul examples for PermissionsExt) - rust-lang#136230 (Reword incorrect documentation about SocketAddr having varying layout) - rust-lang#136892 (Sync Fuchsia target spec with clang Fuchsia driver) - rust-lang#136911 (Add documentation URL to selected jobs) - rust-lang#137870 ( Improve HashMap docs for const and static initializers) - rust-lang#138179 (Add `src/tools/x` to the main workspace) - rust-lang#138389 (use `expect` instead of `allow`) - rust-lang#138396 (Enable metrics and verbose tests in PR CI) - rust-lang#138398 (atomic intrinsics: clarify which types are supported and (if applicable) what happens with provenance) - rust-lang#138432 (fix: remove the check of lld not supporting `@response-file)` - rust-lang#138434 (Visit `PatField` when collecting lint levels) - rust-lang#138441 (update error message) - rust-lang#138442 (EUV: fix place of deref pattern's interior's scrutinee) - rust-lang#138457 (Remove usage of legacy scheme paths on RedoxOS) - rust-lang#138461 (Remove an outdated line from a test comment) - rust-lang#138466 (Remove myself from libs review) Failed merges: - rust-lang#138452 (Remove `RUN_CHECK_WITH_PARALLEL_QUERIES`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#136892 - erickt:fuchsia-target, r=jieyouxu Sync Fuchsia target spec with clang Fuchsia driver This updates the Fuchsia target spec with the [Clang Fuchsia driver], which picks up a few changes: * Adds `-z start-stop-visibility=hidden` and `-z rel` to the pre link arguments. * Adds `--execute-only` and `--fix-cortex-a53-843419` for `aarch64-unknown-fuchsia`. * Enables the equivalent cpu features for `x86-64-v2` for `x86_64-unknown-fuchsia`, which is our minimum supported x86_64 platform according to [RFC-0073]. try-job: x86_64-fuchsia [Clang Fuchsia driver]: https://github.com/llvm/llvm-project/blob/8374d421861cd3d47e21ae7889ba0b4c498e8d85/clang/lib/Driver/ToolChains/Fuchsia.cpp [RFC-0073]: https://fuchsia.dev/fuchsia-src/contribute/governance/rfcs/0073_x86_64_platform_requirement

Rollup of 16 pull requests Successful merges: - rust-lang#136001 (Overhaul examples for PermissionsExt) - rust-lang#136230 (Reword incorrect documentation about SocketAddr having varying layout) - rust-lang#136892 (Sync Fuchsia target spec with clang Fuchsia driver) - rust-lang#136911 (Add documentation URL to selected jobs) - rust-lang#137870 ( Improve HashMap docs for const and static initializers) - rust-lang#138179 (Add `src/tools/x` to the main workspace) - rust-lang#138389 (use `expect` instead of `allow`) - rust-lang#138396 (Enable metrics and verbose tests in PR CI) - rust-lang#138398 (atomic intrinsics: clarify which types are supported and (if applicable) what happens with provenance) - rust-lang#138432 (fix: remove the check of lld not supporting `@response-file)` - rust-lang#138434 (Visit `PatField` when collecting lint levels) - rust-lang#138441 (update error message) - rust-lang#138442 (EUV: fix place of deref pattern's interior's scrutinee) - rust-lang#138457 (Remove usage of legacy scheme paths on RedoxOS) - rust-lang#138461 (Remove an outdated line from a test comment) - rust-lang#138466 (Remove myself from libs review) Failed merges: - rust-lang#138452 (Remove `RUN_CHECK_WITH_PARALLEL_QUERIES`) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned jieyouxu Feb 12, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 12, 2025

erickt marked this pull request as draft February 12, 2025 00:06

jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2025

taiki-e reviewed Feb 12, 2025

View reviewed changes

compiler/rustc_target/src/spec/targets/x86_64_unknown_fuchsia.rs Outdated Show resolved Hide resolved

petrhosek reviewed Feb 12, 2025

View reviewed changes

compiler/rustc_target/src/spec/targets/aarch64_unknown_fuchsia.rs Outdated Show resolved Hide resolved

erickt force-pushed the fuchsia-target branch 5 times, most recently from f937e74 to 57cbfa8 Compare February 12, 2025 19:50

petrhosek reviewed Feb 18, 2025

View reviewed changes

compiler/rustc_target/src/spec/targets/aarch64_unknown_fuchsia.rs Outdated Show resolved Hide resolved

petrhosek reviewed Feb 18, 2025

View reviewed changes

compiler/rustc_target/src/spec/targets/aarch64_unknown_fuchsia.rs Show resolved Hide resolved

petrhosek reviewed Feb 18, 2025

View reviewed changes

compiler/rustc_target/src/spec/targets/riscv64gc_unknown_fuchsia.rs Show resolved Hide resolved

erickt force-pushed the fuchsia-target branch from 57cbfa8 to 5e554d3 Compare February 18, 2025 22:52

erickt requested a review from petrhosek February 18, 2025 22:53

erickt force-pushed the fuchsia-target branch from 5e554d3 to ee372d8 Compare February 20, 2025 01:30

erickt marked this pull request as ready for review February 20, 2025 01:31

This comment has been minimized.

Sign in to view

erickt force-pushed the fuchsia-target branch from ee372d8 to 746b0f6 Compare February 20, 2025 18:44

petrhosek approved these changes Mar 10, 2025

View reviewed changes

jieyouxu added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 13, 2025

jieyouxu approved these changes Mar 14, 2025

View reviewed changes

jieyouxu added the O-fuchsia Operating system: Fuchsia label Mar 14, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2025

jhpratt mentioned this pull request Mar 14, 2025

Rollup of 16 pull requests #138480

Merged

bors merged commit 459352a into rust-lang:master Mar 14, 2025
7 checks passed

rustbot added this to the 1.87.0 milestone Mar 14, 2025

erickt deleted the fuchsia-target branch March 19, 2025 04:11

Sync Fuchsia target spec with clang Fuchsia driver #136892

Sync Fuchsia target spec with clang Fuchsia driver #136892

Uh oh!

Conversation

erickt commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Feb 12, 2025

Uh oh!

rustbot commented Feb 12, 2025

Uh oh!

Uh oh!

Uh oh!

bors commented Feb 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erickt commented Feb 20, 2025

Uh oh!

bors commented Feb 20, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

bors commented Feb 20, 2025

Uh oh!

erickt commented Feb 20, 2025

Uh oh!

bors commented Feb 20, 2025

Uh oh!

bors commented Feb 20, 2025

Uh oh!

jieyouxu commented Mar 10, 2025

Uh oh!

erickt commented Mar 10, 2025

Uh oh!

jieyouxu commented Mar 10, 2025

Uh oh!

erickt commented Mar 13, 2025

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Mar 14, 2025

Uh oh!

bors commented Mar 14, 2025

Uh oh!

Uh oh!

Uh oh!

erickt commented Feb 12, 2025 •

edited

Loading