fix attribute-related ICE when parsing macro on the rhs of a name-value attribute #137622
+87
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-attributes
jdonszelmann
force-pushed
the
fix-137589
branch
from
3a3efc5 to
819c626
Compare
compiler-errors
requested changes
Feb 25, 2025
This comment has been minimized.
This comment has been minimized.
|
well worst of all this fix doesn't work errs, so let me go back and try some more things haha |
jdonszelmann
force-pushed
the
fix-137589
branch
from
819c626 to
4bf66c5
Compare
|
ok, updated things. this checks for all kinds of different cases that could've gone wrong including the two failures from #137589 (which were two separate ICEs actually). |
compiler-errors
approved these changes
Feb 25, 2025
|
ty @bors r+ rollup |
bors
added
S-waiting-on-bors
fmease
added a commit
to fmease/rust
that referenced
this pull request
Feb 26, 2025
…r-errors fix attribute-related ICE when parsing macro on the rhs of a name-value attribute r? `@oli-obk` Closes: rust-lang#137589
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 26, 2025
Rollup of 13 pull requests Successful merges: - rust-lang#136576 (pass optimization level to llvm-bitcode-linker) - rust-lang#137320 (fix(rustdoc): Fixed stability version in rustdoc) - rust-lang#137502 (Don't include global asm in `mir_keys`, fix error body synthesis) - rust-lang#137529 (remove few unused args) - rust-lang#137544 (tests: Add regression test for derive token invalidation (rust-lang#81099)) - rust-lang#137559 (run some tests on emscripten again) - rust-lang#137601 (ssa/mono: deduplicate `type_has_metadata`) - rust-lang#137603 (codegen_llvm: avoid `Deref` impls w/ extern type) - rust-lang#137604 (trait_sel: resolve vars in host effects) - rust-lang#137609 (Complete the list of resources used in rustdoc output) - rust-lang#137613 (hir_analysis: skip self type of host effect preds in variances_of) - rust-lang#137614 (fix doc in library/core/src/pin.rs) - rust-lang#137622 (fix attribute-related ICE when parsing macro on the rhs of a name-value attribute) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 26, 2025
Rollup of 14 pull requests Successful merges: - rust-lang#136576 (pass optimization level to llvm-bitcode-linker) - rust-lang#137154 (Add UTF-8 validation fast paths in `Wtf8Buf`) - rust-lang#137311 (Enable `f16` for MIPS) - rust-lang#137320 (fix(rustdoc): Fixed stability version in rustdoc) - rust-lang#137529 (remove few unused args) - rust-lang#137544 (tests: Add regression test for derive token invalidation (rust-lang#81099)) - rust-lang#137559 (run some tests on emscripten again) - rust-lang#137601 (ssa/mono: deduplicate `type_has_metadata`) - rust-lang#137603 (codegen_llvm: avoid `Deref` impls w/ extern type) - rust-lang#137604 (trait_sel: resolve vars in host effects) - rust-lang#137609 (Complete the list of resources used in rustdoc output) - rust-lang#137613 (hir_analysis: skip self type of host effect preds in variances_of) - rust-lang#137614 (fix doc in library/core/src/pin.rs) - rust-lang#137622 (fix attribute-related ICE when parsing macro on the rhs of a name-value attribute) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 26, 2025
Rollup merge of rust-lang#137622 - jdonszelmann:fix-137589, r=compiler-errors fix attribute-related ICE when parsing macro on the rhs of a name-value attribute r? ``@oli-obk`` Closes: rust-lang#137589
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @oli-obk
Closes: #137589